From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: oss-drivers@netronome.com, netdev@vger.kernel.org,
pieter.jansenvanvuuren@netronome.com
Subject: Re: [PATCH net-next] nfp: flower: prioritize stats updates
Date: Sun, 21 Jan 2018 18:10:00 -0500 (EST) [thread overview]
Message-ID: <20180121.181000.1888376651546300697.davem@davemloft.net> (raw)
In-Reply-To: <20180120015408.16539-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Fri, 19 Jan 2018 17:54:08 -0800
> From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
>
> Previously it was possible to interrupt processing stats updates because
> they were handled in a work queue. Interrupting the stats updates could
> lead to a situation where we backup the control message queue. This patch
> moves the stats update processing out of the work queue to be processed as
> soon as hardware sends a request.
>
> Reported-by: Louis Peens <louis.peens@netronome.com>
> Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Applied, thanks Jakub.
Just a reminder that it really makes things more difficult that one
can't just go:
make drivers/net/ethernet/netronome/nfp/flower/cmsg.o
to test a specific NFP object build like one can with pretty much the
rest of the entire kernel tree.
next prev parent reply other threads:[~2018-01-21 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-20 1:54 [PATCH net-next] nfp: flower: prioritize stats updates Jakub Kicinski
2018-01-21 23:10 ` David Miller [this message]
2018-01-22 7:53 ` Jakub Kicinski
2018-01-22 23:23 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180121.181000.1888376651546300697.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=pieter.jansenvanvuuren@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).