From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] nfp: flower: prioritize stats updates Date: Sun, 21 Jan 2018 18:10:00 -0500 (EST) Message-ID: <20180121.181000.1888376651546300697.davem@davemloft.net> References: <20180120015408.16539-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: oss-drivers@netronome.com, netdev@vger.kernel.org, pieter.jansenvanvuuren@netronome.com To: jakub.kicinski@netronome.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:51682 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbeAUXKL (ORCPT ); Sun, 21 Jan 2018 18:10:11 -0500 In-Reply-To: <20180120015408.16539-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Date: Fri, 19 Jan 2018 17:54:08 -0800 > From: Pieter Jansen van Vuuren > > Previously it was possible to interrupt processing stats updates because > they were handled in a work queue. Interrupting the stats updates could > lead to a situation where we backup the control message queue. This patch > moves the stats update processing out of the work queue to be processed as > soon as hardware sends a request. > > Reported-by: Louis Peens > Signed-off-by: Pieter Jansen van Vuuren > Reviewed-by: Dirk van der Merwe > Reviewed-by: Jakub Kicinski Applied, thanks Jakub. Just a reminder that it really makes things more difficult that one can't just go: make drivers/net/ethernet/netronome/nfp/flower/cmsg.o to test a specific NFP object build like one can with pretty much the rest of the entire kernel tree.