netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: gemini: Depend on HAS_IOMEM
@ 2018-01-21 13:15 Linus Walleij
  2018-01-21 23:06 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2018-01-21 13:15 UTC (permalink / raw)
  To: netdev, David S . Miller, Michał Mirosław
  Cc: Janos Laube, Paulius Zaleckas, linux-arm-kernel, Hans Ulli Kroll,
	Florian Fainelli, Linus Walleij

The zeroday builder notices that since Usermode Linux does not
have IO memory, the build fails for them when selecting everything
it can enable.

As the driver is clearly using memory-mapped registers to access
the network adapter, we add depends on HAS_IOMEM to solve this
problem.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/net/ethernet/cortina/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/cortina/Kconfig b/drivers/net/ethernet/cortina/Kconfig
index 0df743ea51f1..89bc4579724d 100644
--- a/drivers/net/ethernet/cortina/Kconfig
+++ b/drivers/net/ethernet/cortina/Kconfig
@@ -14,6 +14,7 @@ if NET_VENDOR_CORTINA
 config GEMINI_ETHERNET
 	tristate "Gemini Gigabit Ethernet support"
 	depends on OF
+	depends on HAS_IOMEM
 	select PHYLIB
 	select CRC32
 	---help---
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: gemini: Depend on HAS_IOMEM
  2018-01-21 13:15 [PATCH] net: gemini: Depend on HAS_IOMEM Linus Walleij
@ 2018-01-21 23:06 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-01-21 23:06 UTC (permalink / raw)
  To: linus.walleij
  Cc: netdev, mirq-linux, janos.dev, paulius.zaleckas, linux-arm-kernel,
	ulli.kroll, f.fainelli

From: Linus Walleij <linus.walleij@linaro.org>
Date: Sun, 21 Jan 2018 14:15:41 +0100

> The zeroday builder notices that since Usermode Linux does not
> have IO memory, the build fails for them when selecting everything
> it can enable.
> 
> As the driver is clearly using memory-mapped registers to access
> the network adapter, we add depends on HAS_IOMEM to solve this
> problem.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Applied, thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-21 23:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-21 13:15 [PATCH] net: gemini: Depend on HAS_IOMEM Linus Walleij
2018-01-21 23:06 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).