From: David Miller <davem@davemloft.net>
To: sowmini.varadhan@oracle.com
Cc: netdev@vger.kernel.org, santosh.shilimkar@oracle.com
Subject: Re: [PATCH net] rds: tcp: compute m_ack_seq as offset from ->write_seq
Date: Mon, 22 Jan 2018 15:44:08 -0500 (EST) [thread overview]
Message-ID: <20180122.154408.1214672865084237274.davem@davemloft.net> (raw)
In-Reply-To: <1516309867-100563-1-git-send-email-sowmini.varadhan@oracle.com>
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Date: Thu, 18 Jan 2018 13:11:07 -0800
> rds-tcp uses m_ack_seq to track the tcp ack# that indicates
> that the peer has received a rds_message. The m_ack_seq is
> used in rds_tcp_is_acked() to figure out when it is safe to
> drop the rds_message from the RDS retransmit queue.
>
> The m_ack_seq must be calculated as an offset from the right
> edge of the in-flight tcp buffer, i.e., it should be based on
> the ->write_seq, not the ->snd_nxt.
>
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Applied, thanks Sowmini.
prev parent reply other threads:[~2018-01-22 20:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 21:11 [PATCH net] rds: tcp: compute m_ack_seq as offset from ->write_seq Sowmini Varadhan
2018-01-22 20:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122.154408.1214672865084237274.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=santosh.shilimkar@oracle.com \
--cc=sowmini.varadhan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).