From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] rds: tcp: compute m_ack_seq as offset from ->write_seq Date: Mon, 22 Jan 2018 15:44:08 -0500 (EST) Message-ID: <20180122.154408.1214672865084237274.davem@davemloft.net> References: <1516309867-100563-1-git-send-email-sowmini.varadhan@oracle.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, santosh.shilimkar@oracle.com To: sowmini.varadhan@oracle.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:40662 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750996AbeAVUoJ (ORCPT ); Mon, 22 Jan 2018 15:44:09 -0500 In-Reply-To: <1516309867-100563-1-git-send-email-sowmini.varadhan@oracle.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Sowmini Varadhan Date: Thu, 18 Jan 2018 13:11:07 -0800 > rds-tcp uses m_ack_seq to track the tcp ack# that indicates > that the peer has received a rds_message. The m_ack_seq is > used in rds_tcp_is_acked() to figure out when it is safe to > drop the rds_message from the RDS retransmit queue. > > The m_ack_seq must be calculated as an offset from the right > edge of the in-flight tcp buffer, i.e., it should be based on > the ->write_seq, not the ->snd_nxt. > > Signed-off-by: Sowmini Varadhan Applied, thanks Sowmini.