From: David Miller <davem@davemloft.net>
To: nbd@nbd.name
Cc: netdev@vger.kernel.org, cernekee@chromium.org, s.gottschall@dd-wrt.com
Subject: Re: [PATCH] net: igmp: fix source address check for IGMPv3 reports
Date: Mon, 22 Jan 2018 16:17:58 -0500 (EST) [thread overview]
Message-ID: <20180122.161758.859663134125125839.davem@davemloft.net> (raw)
In-Reply-To: <20180119105046.44870-1-nbd@nbd.name>
From: Felix Fietkau <nbd@nbd.name>
Date: Fri, 19 Jan 2018 11:50:46 +0100
> Commit "net: igmp: Use correct source address on IGMPv3 reports"
> introduced a check to validate the source address of locally generated
> IGMPv3 packets.
> Instead of checking the local interface address directly, it uses
> inet_ifa_match(fl4->saddr, ifa), which checks if the address is on the
> local subnet (or equal to the point-to-point address if used).
>
> This breaks for point-to-point interfaces, so check against
> ifa->ifa_local directly.
>
> Cc: Kevin Cernekee <cernekee@chromium.org>
> Fixes: a46182b00290 ("net: igmp: Use correct source address on IGMPv3 reports")
> Reported-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
Applied, thanks.
next prev parent reply other threads:[~2018-01-22 21:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 10:50 [PATCH] net: igmp: fix source address check for IGMPv3 reports Felix Fietkau
2018-01-22 21:17 ` David Miller [this message]
2018-01-23 9:48 ` Felix Fietkau
2018-01-23 16:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122.161758.859663134125125839.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cernekee@chromium.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=s.gottschall@dd-wrt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).