From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] net: igmp: fix source address check for IGMPv3 reports
Date: Mon, 22 Jan 2018 16:17:58 -0500 (EST)
Message-ID: <20180122.161758.859663134125125839.davem@davemloft.net>
References: <20180119105046.44870-1-nbd@nbd.name>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, cernekee@chromium.org,
        s.gottschall@dd-wrt.com
To: nbd@nbd.name
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:41234 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750878AbeAVVR7 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 22 Jan 2018 16:17:59 -0500
In-Reply-To: <20180119105046.44870-1-nbd@nbd.name>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Felix Fietkau <nbd@nbd.name>
Date: Fri, 19 Jan 2018 11:50:46 +0100

> Commit "net: igmp: Use correct source address on IGMPv3 reports"
> introduced a check to validate the source address of locally generated
> IGMPv3 packets.
> Instead of checking the local interface address directly, it uses
> inet_ifa_match(fl4->saddr, ifa), which checks if the address is on the
> local subnet (or equal to the point-to-point address if used).
> 
> This breaks for point-to-point interfaces, so check against
> ifa->ifa_local directly.
> 
> Cc: Kevin Cernekee <cernekee@chromium.org>
> Fixes: a46182b00290 ("net: igmp: Use correct source address on IGMPv3 reports")
> Reported-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>

Applied, thanks.