From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2] tc/lexer: let quotes actually start strings Date: Mon, 22 Jan 2018 09:09:34 -0800 Message-ID: <20180122090934.0b56abfb@xeon-e3> References: <20180122105346.15367-1-w.bumiller@proxmox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Wolfgang Bumiller Return-path: Received: from mail-pg0-f48.google.com ([74.125.83.48]:45335 "EHLO mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751028AbeAVRJh (ORCPT ); Mon, 22 Jan 2018 12:09:37 -0500 Received: by mail-pg0-f48.google.com with SMTP id m136so615294pga.12 for ; Mon, 22 Jan 2018 09:09:37 -0800 (PST) In-Reply-To: <20180122105346.15367-1-w.bumiller@proxmox.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 22 Jan 2018 11:53:46 +0100 Wolfgang Bumiller wrote: > The lexer will go with the longest match, so previously > the starting double quotes of a string would be swallowed by > the [^ \t\r\n()]+ pattern leaving the user no way to > actually use strings with escape sequences. > Fix this by not allowing this case to start with double > quotes. > > Signed-off-by: Wolfgang Bumiller > --- This is the same patch you posted earlier. It looked fine, just that it needs some time for people on mailing list to review.