[PATCH net-next v2] net: link_watch: mark bonding link events urgent

[PATCH net-next v2] net: link_watch: mark bonding link events urgent

[Roopa Prabhu]

From: Roopa Prabhu <roopa@cumulusnetworks.com>

It takes 1sec for bond link down notification to hit user-space
when all slaves of the bond go down. 1sec is too long for
protocol daemons in user-space relying on bond notification
to recover (eg: multichassis lag implementations in user-space).
Since the link event code already marks team device port link events
 as urgent, this patch moves the code to cover all lag ports and master.

Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
---
v2: use netif_is_lag_* api's as suggested by jiri

 net/core/link_watch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/link_watch.c b/net/core/link_watch.c
index 9828616..e38e641 100644
--- a/net/core/link_watch.c
+++ b/net/core/link_watch.c
@@ -92,7 +92,7 @@ static bool linkwatch_urgent_event(struct net_device *dev)
 	if (dev->ifindex != dev_get_iflink(dev))
 		return true;
 
-	if (dev->priv_flags & IFF_TEAM_PORT)
+	if (netif_is_lag_port(dev) || netif_is_lag_master(dev))
 		return true;
 
 	return netif_carrier_ok(dev) &&	qdisc_tx_changing(dev);
-- 
2.1.4

Re: [PATCH net-next v2] net: link_watch: mark bonding link events urgent

[Jiri Pirko]

Mon, Jan 22, 2018 at 05:07:19PM CET, roopa@cumulusnetworks.com wrote:
>From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
>It takes 1sec for bond link down notification to hit user-space
>when all slaves of the bond go down. 1sec is too long for
>protocol daemons in user-space relying on bond notification
>to recover (eg: multichassis lag implementations in user-space).
>Since the link event code already marks team device port link events
> as urgent, this patch moves the code to cover all lag ports and master.
>
>Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>

Acked-by: Jiri Pirko <jiri@mellanox.com>

Re: [PATCH net-next v2] net: link_watch: mark bonding link events urgent

[Nikolay Aleksandrov]

On 22/01/18 18:07, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> 
> It takes 1sec for bond link down notification to hit user-space
> when all slaves of the bond go down. 1sec is too long for
> protocol daemons in user-space relying on bond notification
> to recover (eg: multichassis lag implementations in user-space).
> Since the link event code already marks team device port link events
>  as urgent, this patch moves the code to cover all lag ports and master.
> 
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> ---
> v2: use netif_is_lag_* api's as suggested by jiri
> 
>  net/core/link_watch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/link_watch.c b/net/core/link_watch.c
> index 9828616..e38e641 100644
> --- a/net/core/link_watch.c
> +++ b/net/core/link_watch.c
> @@ -92,7 +92,7 @@ static bool linkwatch_urgent_event(struct net_device *dev)
>  	if (dev->ifindex != dev_get_iflink(dev))
>  		return true;
>  
> -	if (dev->priv_flags & IFF_TEAM_PORT)
> +	if (netif_is_lag_port(dev) || netif_is_lag_master(dev))
>  		return true;
>  
>  	return netif_carrier_ok(dev) &&	qdisc_tx_changing(dev);
> 

Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>

Re: [PATCH net-next v2] net: link_watch: mark bonding link events urgent

[David Miller]

From: Roopa Prabhu <roopa@cumulusnetworks.com>
Date: Mon, 22 Jan 2018 08:07:19 -0800

> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> 
> It takes 1sec for bond link down notification to hit user-space
> when all slaves of the bond go down. 1sec is too long for
> protocol daemons in user-space relying on bond notification
> to recover (eg: multichassis lag implementations in user-space).
> Since the link event code already marks team device port link events
>  as urgent, this patch moves the code to cover all lag ports and master.
> 
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> ---
> v2: use netif_is_lag_* api's as suggested by jiri

Applied, thanks Roopa.