From: Jiri Benc <jbenc@redhat.com>
To: Serhey Popovych <serhe.popovych@gmail.com>
Cc: netdev@vger.kernel.org, u9012063@gmail.com, julien@cumulusnetworks.com
Subject: Re: [PATCH iproute2-next 1/2] ip/tunnel: Be consistent when printing tunnel collect metadata
Date: Mon, 22 Jan 2018 17:58:41 +0100 [thread overview]
Message-ID: <20180122175841.71400890@redhat.com> (raw)
In-Reply-To: <1516639614-12960-2-git-send-email-serhe.popovych@gmail.com>
On Mon, 22 Jan 2018 18:46:53 +0200, Serhey Popovych wrote:
> + if (tb[IFLA_GRE_COLLECT_METADATA]) {
> + print_bool(PRINT_ANY, "collect_metadata", "external", true);
> + return;
> + }
Nacked-by: Jiri Benc <jbenc@redhat.com>
Don't ever use "collect_metadata" for anything visible to the user.
collect_metadata is a *horrible* name. It describes the internal
implementation of the lwtunneling in the kernel and provides zero
explanation to the user about what's that feature good for.
The netlink attribute should have never had such name but it's uAPI and
we have to live with it. But there's no reason to expose this to the
user.
Stick with the "external" name. It explains what it is about: instead of
the traffic being controlled by the tunnel internal logic (or tunnel
control plane, if you want), an external logic needs to be attached to
the tunnel in order for the tunneling to work.
Jiri
next prev parent reply other threads:[~2018-01-22 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 16:46 [PATCH iproute2-next 0/2] ip/tunnel: Unify collect metadata handling Serhey Popovych
2018-01-22 16:46 ` [PATCH iproute2-next 1/2] ip/tunnel: Be consistent when printing tunnel collect metadata Serhey Popovych
2018-01-22 16:58 ` Jiri Benc [this message]
2018-01-22 17:00 ` Serhey Popovych
2018-01-22 16:46 ` [PATCH iproute2-next 2/2] gre/gre6: Unify attribute addition to netlink buffer Serhey Popovych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122175841.71400890@redhat.com \
--to=jbenc@redhat.com \
--cc=julien@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=serhe.popovych@gmail.com \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).