From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: [bpf-next PATCH v4 6/7] bpf: sockmap put client sockets in blocking mode Date: Mon, 22 Jan 2018 10:36:53 -0800 Message-ID: <20180122183653.11150.8018.stgit@john-Precision-Tower-5810> References: <20180122183256.11150.69794.stgit@john-Precision-Tower-5810> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, brouer@redhat.com To: borkmann@iogearbox.net, kafai@fb.com, ast@kernel.org Return-path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:44209 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbeAVShF (ORCPT ); Mon, 22 Jan 2018 13:37:05 -0500 Received: by mail-pg0-f68.google.com with SMTP id m20so7736289pgc.11 for ; Mon, 22 Jan 2018 10:37:05 -0800 (PST) In-Reply-To: <20180122183256.11150.69794.stgit@john-Precision-Tower-5810> Sender: netdev-owner@vger.kernel.org List-ID: Put client sockets in blocking mode otherwise with sendmsg tests its easy to overrun the socket buffers which results in the test being aborted. The original non-blocking was added to handle listen/accept with a single thread the client/accepted sockets do not need to be non-blocking. Signed-off-by: John Fastabend Acked-by: Martin KaFai Lau --- samples/sockmap/sockmap_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/sockmap/sockmap_user.c b/samples/sockmap/sockmap_user.c index f9d3785..fe943c9 100644 --- a/samples/sockmap/sockmap_user.c +++ b/samples/sockmap/sockmap_user.c @@ -109,7 +109,7 @@ static int sockmap_init_sockets(void) } /* Non-blocking sockets */ - for (i = 0; i < 4; i++) { + for (i = 0; i < 2; i++) { err = ioctl(*fds[i], FIONBIO, (char *)&one); if (err < 0) { perror("ioctl s1 failed()");