From: Ivan Mikhaylov <ivan@de.ibm.com>
To: Christian Lamparter <chunkeey@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Rob Herring <robh@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net/ibm/emac: wrong bit is used for STA control register write
Date: Mon, 22 Jan 2018 22:01:46 +0300 [thread overview]
Message-ID: <20180122190146.22876-1-ivan@de.ibm.com> (raw)
In-Reply-To: <2818110.k5nooOEKBD@debian64>
>Something looks wrong here?! The commit message talks about bit 18, 19 and 20.
>However, 0x0800, 0x1000, 0x2000 and are like bit 11, 12 and 13? Furthermore,
>what about the EMAC_STACR_STAC_MASK? shouldn't it be 0x1800 now (or delete it
>since it doesn't look like it's used anywhere?).
Christian, nope, it's all fine there, it's big endian. This commit related only
to write operation, I'll check MASK and see what I can do with that.
next prev parent reply other threads:[~2018-01-22 19:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 16:00 [PATCH 2/2] net/ibm/emac: wrong bit is used for STA control register write Ivan Mikhaylov
2018-01-22 16:22 ` Christian Lamparter
2018-01-22 19:01 ` Ivan Mikhaylov [this message]
2018-01-22 20:29 ` Christian Lamparter
2018-01-23 16:44 ` Ivan Mikhaylov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122190146.22876-1-ivan@de.ibm.com \
--to=ivan@de.ibm.com \
--cc=chunkeey@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).