From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Mikhaylov Subject: Re: [PATCH 2/2] net/ibm/emac: wrong bit is used for STA control register write Date: Mon, 22 Jan 2018 22:01:46 +0300 Message-ID: <20180122190146.22876-1-ivan@de.ibm.com> References: <2818110.k5nooOEKBD@debian64> Cc: "David S . Miller" , Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Christian Lamparter Return-path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38994 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbeAVTB6 (ORCPT ); Mon, 22 Jan 2018 14:01:58 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0MJ0ZNu061595 for ; Mon, 22 Jan 2018 14:01:57 -0500 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0a-001b2d01.pphosted.com with ESMTP id 2fnhbkx0k5-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 22 Jan 2018 14:01:54 -0500 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 22 Jan 2018 19:01:52 -0000 In-Reply-To: <2818110.k5nooOEKBD@debian64> Sender: netdev-owner@vger.kernel.org List-ID: >Something looks wrong here?! The commit message talks about bit 18, 19 and 20. >However, 0x0800, 0x1000, 0x2000 and are like bit 11, 12 and 13? Furthermore, >what about the EMAC_STACR_STAC_MASK? shouldn't it be 0x1800 now (or delete it >since it doesn't look like it's used anywhere?). Christian, nope, it's all fine there, it's big endian. This commit related only to write operation, I'll check MASK and see what I can do with that.