From: David Miller <davem@davemloft.net>
To: garsilva@embeddedor.com
Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ipv6: ndisc: fix bool assignment in ndisc_send_na
Date: Tue, 23 Jan 2018 10:02:17 -0500 (EST) [thread overview]
Message-ID: <20180123.100217.2156136452621715003.davem@davemloft.net> (raw)
In-Reply-To: <20180122222213.GA14829@embeddedor.com>
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date: Mon, 22 Jan 2018 16:22:13 -0600
> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Fixes: 1cb3fe513f62 ("ndisc: Break down ndisc_build_skb() and build message directly.")
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Please don't use the word "fix".
'0' is the same as 'false', it's just that the latter is more
consistent type wise.
You aren't fixing any bugs with these changes at all.
next prev parent reply other threads:[~2018-01-23 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 22:22 [PATCH] net: ipv6: ndisc: fix bool assignment in ndisc_send_na Gustavo A. R. Silva
2018-01-23 15:02 ` David Miller [this message]
2018-01-23 15:21 ` Gustavo A. R. Silva
2018-01-23 16:28 ` David Miller
2018-01-23 16:30 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123.100217.2156136452621715003.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=garsilva@embeddedor.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).