From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: ipv6: ndisc: fix bool assignment in ndisc_send_na Date: Tue, 23 Jan 2018 10:02:17 -0500 (EST) Message-ID: <20180123.100217.2156136452621715003.davem@davemloft.net> References: <20180122222213.GA14829@embeddedor.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: garsilva@embeddedor.com Return-path: In-Reply-To: <20180122222213.GA14829@embeddedor.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: "Gustavo A. R. Silva" Date: Mon, 22 Jan 2018 16:22:13 -0600 > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. > > Fixes: 1cb3fe513f62 ("ndisc: Break down ndisc_build_skb() and build message directly.") > Signed-off-by: Gustavo A. R. Silva Please don't use the word "fix". '0' is the same as 'false', it's just that the latter is more consistent type wise. You aren't fixing any bugs with these changes at all.