From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] nfp: fix fw dump handling of absolute rtsym size Date: Tue, 23 Jan 2018 10:30:52 -0500 (EST) Message-ID: <20180123.103052.2237069996431058068.davem@davemloft.net> References: <20180123012943.14943-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, carl.heymann@netronome.com To: jakub.kicinski@netronome.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:54096 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214AbeAWPax (ORCPT ); Tue, 23 Jan 2018 10:30:53 -0500 In-Reply-To: <20180123012943.14943-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Date: Mon, 22 Jan 2018 17:29:43 -0800 > From: Carl Heymann > > Fix bug that causes _absolute_ rtsym sizes of > 8 bytes (as per symbol > table) to result in incorrect space used during a TLV-based debug dump. > > Detail: The size calculation stage calculates the correct size (size of > the rtsym address field == 8), while the dump uses the size in the table > to calculate the TLV size to reserve. Symbols with size <= 8 are handled > OK due to aligning sizes to 8, but including any absolute symbol with > listed size > 8 leads to an ENOSPC error during the dump. > > Fixes: da762863edd9 ("nfp: fix absolute rtsym handling in debug dump") > Signed-off-by: Carl Heymann > Reviewed-by: Jakub Kicinski Applied, thanks.