* [PATCH net-next] net: aquantia: make symbol hw_atl_boards static
@ 2018-01-23 2:10 Wei Yongjun
2018-01-23 7:13 ` Igor Russkikh
2018-01-23 15:59 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2018-01-23 2:10 UTC (permalink / raw)
To: David Arcari, Colin Ian King, David VomLehn, Igor Russkikh,
Pavel Belous, Dmitrii Tarakanov, Alexander Loktionov
Cc: Wei Yongjun, netdev, kernel-janitors
Fixes the following sparse warning:
drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c:50:34: warning:
symbol 'hw_atl_boards' was not declared. Should it be static?
Fixes: 4948293ff963 ("net: aquantia: Introduce new AQC devices and capabilities")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
index f5dd5f7..51a1a90 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
@@ -47,7 +47,7 @@
{}
};
-const struct aq_board_revision_s hw_atl_boards[] = {
+static const struct aq_board_revision_s hw_atl_boards[] = {
{ AQ_DEVICE_ID_0001, AQ_HWREV_1, &hw_atl_ops_a0, &hw_atl_a0_caps_aqc107, },
{ AQ_DEVICE_ID_D100, AQ_HWREV_1, &hw_atl_ops_a0, &hw_atl_a0_caps_aqc100, },
{ AQ_DEVICE_ID_D107, AQ_HWREV_1, &hw_atl_ops_a0, &hw_atl_a0_caps_aqc107, },
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: aquantia: make symbol hw_atl_boards static
2018-01-23 2:10 [PATCH net-next] net: aquantia: make symbol hw_atl_boards static Wei Yongjun
@ 2018-01-23 7:13 ` Igor Russkikh
2018-01-23 15:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Igor Russkikh @ 2018-01-23 7:13 UTC (permalink / raw)
To: Wei Yongjun, David Arcari, Colin Ian King, David VomLehn,
Pavel Belous, Dmitrii Tarakanov, Alexander Loktionov
Cc: netdev, kernel-janitors
Thanks, Wei!
> Fixes the following sparse warning:
>
> drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c:50:34: warning:
> symbol 'hw_atl_boards' was not declared. Should it be static?
>
> Fixes: 4948293ff963 ("net: aquantia: Introduce new AQC devices and capabilities")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Igor Russkikh <igor.russkikh@aquantia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: aquantia: make symbol hw_atl_boards static
2018-01-23 2:10 [PATCH net-next] net: aquantia: make symbol hw_atl_boards static Wei Yongjun
2018-01-23 7:13 ` Igor Russkikh
@ 2018-01-23 15:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-01-23 15:59 UTC (permalink / raw)
To: weiyongjun1
Cc: darcari, colin.king, vomlehn, igor.russkikh, pavel.belous,
Dmitrii.Tarakanov, Alexander.Loktionov, netdev, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Tue, 23 Jan 2018 02:10:38 +0000
> Fixes the following sparse warning:
>
> drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c:50:34: warning:
> symbol 'hw_atl_boards' was not declared. Should it be static?
>
> Fixes: 4948293ff963 ("net: aquantia: Introduce new AQC devices and capabilities")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-23 15:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-23 2:10 [PATCH net-next] net: aquantia: make symbol hw_atl_boards static Wei Yongjun
2018-01-23 7:13 ` Igor Russkikh
2018-01-23 15:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).