From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: rasesh.mody@cavium.com, harish.patil@cavium.com,
Dept-GELinuxNICDev@cavium.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bnx2: remove redundant initializations of pointers txr and rxr
Date: Tue, 23 Jan 2018 11:17:25 -0500 (EST) [thread overview]
Message-ID: <20180123.111725.1910125353313770902.davem@davemloft.net> (raw)
In-Reply-To: <20180123094408.30366-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Tue, 23 Jan 2018 09:44:08 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointers txr and rxr are being initialized and a few statements later
> are being assigned new values without the original values ever being
> read. The initialized values are therefore redundant and can be
> removed.
>
> Cleans up clang warnings:
> drivers/net/ethernet/broadcom/bnx2.c:5821:28: warning: Value stored to
> 'txr' during its initialization is never read
> drivers/net/ethernet/broadcom/bnx2.c:5822:28: warning: Value stored to
> 'rxr' during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks Colin.
prev parent reply other threads:[~2018-01-23 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 9:44 [PATCH] bnx2: remove redundant initializations of pointers txr and rxr Colin King
2018-01-23 16:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123.111725.1910125353313770902.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept-GELinuxNICDev@cavium.com \
--cc=colin.king@canonical.com \
--cc=harish.patil@cavium.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rasesh.mody@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).