From: David Miller <davem@davemloft.net>
To: ganeshgr@chelsio.com
Cc: netdev@vger.kernel.org, nirranjan@chelsio.com,
indranil@chelsio.com, venkatesh@chelsio.com
Subject: Re: [PATCH net-next] cxgb4/cxgb4vf: add support for ndo_set_vf_vlan
Date: Tue, 23 Jan 2018 13:27:35 -0500 (EST) [thread overview]
Message-ID: <20180123.132735.489931369264140861.davem@davemloft.net> (raw)
In-Reply-To: <1516724523-27972-1-git-send-email-ganeshgr@chelsio.com>
From: Ganesh Goudar <ganeshgr@chelsio.com>
Date: Tue, 23 Jan 2018 21:52:03 +0530
> + cmd.op_to_vfn = htonl(FW_CMD_OP_V(FW_ACL_VLAN_CMD) |
> + FW_CMD_REQUEST_F | FW_CMD_READ_F);
> +
> + /* Note: Do not enable the ACL */
> + cmd.en_to_len16 = htonl((unsigned int)FW_LEN16(cmd));
This is inconsistent with the rest of the driver which uses
cpu_to_be??() when filling in firmware commands.
Please fix this.
Thank you.
prev parent reply other threads:[~2018-01-23 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 16:22 [PATCH net-next] cxgb4/cxgb4vf: add support for ndo_set_vf_vlan Ganesh Goudar
2018-01-23 18:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123.132735.489931369264140861.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ganeshgr@chelsio.com \
--cc=indranil@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=venkatesh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).