From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next] cxgb4/cxgb4vf: add support for ndo_set_vf_vlan
Date: Tue, 23 Jan 2018 13:27:35 -0500 (EST)
Message-ID: <20180123.132735.489931369264140861.davem@davemloft.net>
References: <1516724523-27972-1-git-send-email-ganeshgr@chelsio.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, nirranjan@chelsio.com,
        indranil@chelsio.com, venkatesh@chelsio.com
To: ganeshgr@chelsio.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:57310 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752279AbeAWS1h (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 23 Jan 2018 13:27:37 -0500
In-Reply-To: <1516724523-27972-1-git-send-email-ganeshgr@chelsio.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Ganesh Goudar <ganeshgr@chelsio.com>
Date: Tue, 23 Jan 2018 21:52:03 +0530

> +	cmd.op_to_vfn = htonl(FW_CMD_OP_V(FW_ACL_VLAN_CMD) |
> +			      FW_CMD_REQUEST_F | FW_CMD_READ_F);
> +
> +	/* Note: Do not enable the ACL */
> +	cmd.en_to_len16 = htonl((unsigned int)FW_LEN16(cmd));

This is inconsistent with the rest of the driver which uses
cpu_to_be??() when filling in firmware commands.

Please fix this.

Thank you.