From: David Miller <davem@davemloft.net>
To: dcaratti@redhat.com
Cc: xiyou.wangcong@gmail.com, netdev@vger.kernel.org, jiri@resnulli.us
Subject: Re: [PATCH net-next v3 0/2] net/sched: remove spinlock from 'csum' action
Date: Tue, 23 Jan 2018 19:52:06 -0500 (EST) [thread overview]
Message-ID: <20180123.195206.306046166006716936.davem@davemloft.net> (raw)
In-Reply-To: <cover.1516635794.git.dcaratti@redhat.com>
From: Davide Caratti <dcaratti@redhat.com>
Date: Mon, 22 Jan 2018 18:14:30 +0100
> Similarly to what has been done earlier with other actions [1][2], this
> series tries to improve the performance of 'csum' tc action, removing a
> spinlock in the data path. Patch 1 lets act_csum use per-CPU counters;
> patch 2 removes spin_{,un}lock_bh() calls from the act() method.
>
> test procedure (using pktgen from https://github.com/netoptimizer):
>
> # ip link add name eth1 type dummy
> # ip link set dev eth1 up
> # tc qdisc add dev eth1 root handle 1: prio
> # for a in pass drop; do
> > tc filter del dev eth1 parent 1: pref 10 matchall action csum udp
> > tc filter add dev eth1 parent 1: pref 10 matchall action csum udp $a
> > for n in 2 4; do
> > ./pktgen_bench_xmit_mode_queue_xmit.sh -v -s 64 -t $n -n 1000000 -i eth1
> > done
> > done
>
> test results:
>
> | | before patch | after patch
> $a | $n | avg. pps/thread | avg. pps/thread
> -----+----+-----------------+----------------
> pass | 2 | 1671463 ± 4% | 1920789 ± 3%
> pass | 4 | 648797 ± 1% | 738190 ± 1%
> drop | 2 | 3212692 ± 2% | 3719811 ± 2%
> drop | 4 | 1078824 ± 1% | 1328099 ± 1%
>
> references:
>
> [1] https://www.spinics.net/lists/netdev/msg334760.html
> [2] https://www.spinics.net/lists/netdev/msg465862.html
Series applied, thanks Davide.
prev parent reply other threads:[~2018-01-24 0:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 17:14 [PATCH net-next v3 0/2] net/sched: remove spinlock from 'csum' action Davide Caratti
2018-01-22 17:14 ` [PATCH net-next v3 1/2] net/sched: act_csum: use per-core statistics Davide Caratti
2018-01-22 17:14 ` [PATCH net-next v3 2/2] net/sched: act_csum: don't use spinlock in the fast path Davide Caratti
2018-01-22 20:23 ` [PATCH net-next v3 0/2] net/sched: remove spinlock from 'csum' action Cong Wang
2018-01-24 0:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123.195206.306046166006716936.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).