From: David Miller <davem@davemloft.net>
To: ben.hutchings@codethink.co.uk
Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv6: Fix getsockopt() for sockets with default IPV6_AUTOFLOWLABEL
Date: Tue, 23 Jan 2018 19:55:52 -0500 (EST) [thread overview]
Message-ID: <20180123.195552.1920721101735461569.davem@davemloft.net> (raw)
In-Reply-To: <20180122200642.es6qqlsjzj2jeg6p@xylophone.i.decadent.org.uk>
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
Date: Mon, 22 Jan 2018 20:06:42 +0000
> Commit 513674b5a2c9 ("net: reevalulate autoflowlabel setting after
> sysctl setting") removed the initialisation of
> ipv6_pinfo::autoflowlabel and added a second flag to indicate
> whether this field or the net namespace default should be used.
>
> The getsockopt() handling for this case was not updated, so it
> currently returns 0 for all sockets for which IPV6_AUTOFLOWLABEL is
> not explicitly enabled. Fix it to return the effective value, whether
> that has been set at the socket or net namespace level.
>
> Fixes: 513674b5a2c9 ("net: reevalulate autoflowlabel setting after sysctl ...")
> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> ---
> This will need to go to stable, as the earlier commit did.
Applied and queued up for -stable, thanks Ben.
prev parent reply other threads:[~2018-01-24 0:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 20:06 [PATCH net] ipv6: Fix getsockopt() for sockets with default IPV6_AUTOFLOWLABEL Ben Hutchings
2018-01-24 0:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123.195552.1920721101735461569.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben.hutchings@codethink.co.uk \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).