From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] ipv6: Fix getsockopt() for sockets with default IPV6_AUTOFLOWLABEL Date: Tue, 23 Jan 2018 19:55:52 -0500 (EST) Message-ID: <20180123.195552.1920721101735461569.davem@davemloft.net> References: <20180122200642.es6qqlsjzj2jeg6p@xylophone.i.decadent.org.uk> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org To: ben.hutchings@codethink.co.uk Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:34780 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752725AbeAXAzz (ORCPT ); Tue, 23 Jan 2018 19:55:55 -0500 In-Reply-To: <20180122200642.es6qqlsjzj2jeg6p@xylophone.i.decadent.org.uk> Sender: netdev-owner@vger.kernel.org List-ID: From: Ben Hutchings Date: Mon, 22 Jan 2018 20:06:42 +0000 > Commit 513674b5a2c9 ("net: reevalulate autoflowlabel setting after > sysctl setting") removed the initialisation of > ipv6_pinfo::autoflowlabel and added a second flag to indicate > whether this field or the net namespace default should be used. > > The getsockopt() handling for this case was not updated, so it > currently returns 0 for all sockets for which IPV6_AUTOFLOWLABEL is > not explicitly enabled. Fix it to return the effective value, whether > that has been set at the socket or net namespace level. > > Fixes: 513674b5a2c9 ("net: reevalulate autoflowlabel setting after sysctl ...") > Signed-off-by: Ben Hutchings > --- > This will need to go to stable, as the earlier commit did. Applied and queued up for -stable, thanks Ben.