[PATCH net-next 0/4] Kernel doc fixes for networking

netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH net-next 0/4] Kernel doc fixes for networking
@ 2018-01-23  3:14 Florian Fainelli
  2018-01-23  3:14 ` [PATCH net-next 1/4] net: core: Fix kernel-doc for carrier_* attributes Florian Fainelli
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Florian Fainelli @ 2018-01-23  3:14 UTC (permalink / raw)
  To: netdev
  Cc: Florian Fainelli, Andrew Lunn, David S. Miller, Daniel Borkmann,
	Eric Dumazet, Jakub Kicinski, Jesper Dangaard Brouer,
	Rasmus Villemoes, John Fastabend, tcharding, Ido Schimmel,
	open list

Hi David,

This patch series fixes kernel doc warnings found while running make htmldocs
pertaining to the networking subsystem. There is a finaly set of warnings due
to PHYLINK which I have not been able to resolve yet.

The last patch could thereoteically be applied to 'net' since the commit
referenced by the Fixes: tag is present in v4.15-rcX.

Thanks

Florian Fainelli (4):
  net: core: Fix kernel-doc for carrier_* attributes
  net: phy: sfp: Fix kernel doc warning
  net: core: Fix kernel-doc for call_netdevice_notifiers_info()
  net: core: Fix kernel-doc for netdev_upper_link()

 drivers/net/phy/sfp-bus.c | 2 +-
 include/linux/netdevice.h | 4 ++--
 net/core/dev.c            | 3 ++-
 3 files changed, 5 insertions(+), 4 deletions(-)

-- 
2.14.1

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH net-next 1/4] net: core: Fix kernel-doc for carrier_* attributes
  2018-01-23  3:14 [PATCH net-next 0/4] Kernel doc fixes for networking Florian Fainelli
@ 2018-01-23  3:14 ` Florian Fainelli
  2018-01-25  0:25   ` kbuild test robot
  2018-01-23  3:14 ` [PATCH net-next 2/4] net: phy: sfp: Fix kernel doc warning Florian Fainelli
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 7+ messages in thread
From: Florian Fainelli @ 2018-01-23  3:14 UTC (permalink / raw)
  To: netdev
  Cc: Florian Fainelli, Andrew Lunn, David S. Miller, Daniel Borkmann,
	Eric Dumazet, Jakub Kicinski, Jesper Dangaard Brouer,
	Rasmus Villemoes, John Fastabend, tcharding, Ido Schimmel,
	open list

Fix the documentation warning:

include/linux/netdevice.h:1939: warning: Excess struct member 'carrier_changes' description in 'net_device'

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Fixes: b2d3bcfa26a7 ("net: core: Expose number of link up/down transitions")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 include/linux/netdevice.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 837e9cb7e358..581495f4e487 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1469,8 +1469,6 @@ enum netdev_priv_flags {
  *	@base_addr:	Device I/O address
  *	@irq:		Device IRQ number
  *
- *	@carrier_changes:	Stats to monitor carrier on<->off transitions
- *
  *	@state:		Generic network queuing layer state, see netdev_state_t
  *	@dev_list:	The global list of network devices
  *	@napi_list:	List entry used for polling NAPI devices
@@ -1506,6 +1504,8 @@ enum netdev_priv_flags {
  *			do not use this in drivers
  *	@rx_nohandler:	nohandler dropped packets by core network on
  *			inactive devices, do not use this in drivers
+ *	@carrier_up_count:	Number of times the carrier has been up
+ *	@carrier_down_count:	Number of times the carrier has been down
  *
  *	@wireless_handlers:	List of functions to handle Wireless Extensions,
  *				instead of ioctl,
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH net-next 1/4] net: core: Fix kernel-doc for carrier_* attributes
  2018-01-23  3:14 ` [PATCH net-next 1/4] net: core: Fix kernel-doc for carrier_* attributes Florian Fainelli
@ 2018-01-25  0:25   ` kbuild test robot
  0 siblings, 0 replies; 7+ messages in thread
From: kbuild test robot @ 2018-01-25  0:25 UTC (permalink / raw)
  To: Florian Fainelli
  Cc: kbuild-all, netdev, Florian Fainelli, Andrew Lunn,
	David S. Miller, Daniel Borkmann, Eric Dumazet, Jakub Kicinski,
	Jesper Dangaard Brouer, Rasmus Villemoes, John Fastabend,
	tcharding, Ido Schimmel, open list

[-- Attachment #1: Type: text/plain, Size: 23321 bytes --]

Hi Florian,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-core-Fix-kernel-doc-for-carrier_-attributes/20180125-062300
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   Warning: Could not extract kernel version
   WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org)
   include/crypto/hash.h:89: warning: duplicate section name 'Note'
   include/crypto/hash.h:95: warning: duplicate section name 'Note'
   include/crypto/hash.h:102: warning: duplicate section name 'Note'
   include/crypto/hash.h:89: warning: duplicate section name 'Note'
   include/crypto/hash.h:95: warning: duplicate section name 'Note'
   include/crypto/hash.h:102: warning: duplicate section name 'Note'
   include/crypto/hash.h:89: warning: duplicate section name 'Note'
   include/crypto/hash.h:95: warning: duplicate section name 'Note'
   include/crypto/hash.h:102: warning: duplicate section name 'Note'
   include/crypto/hash.h:89: warning: duplicate section name 'Note'
   include/crypto/hash.h:95: warning: duplicate section name 'Note'
   include/crypto/hash.h:102: warning: duplicate section name 'Note'
   include/crypto/hash.h:89: warning: duplicate section name 'Note'
   include/crypto/hash.h:95: warning: duplicate section name 'Note'
   include/crypto/hash.h:102: warning: duplicate section name 'Note'
   include/crypto/hash.h:89: warning: duplicate section name 'Note'
   include/crypto/hash.h:95: warning: duplicate section name 'Note'
   include/crypto/hash.h:102: warning: duplicate section name 'Note'
   include/crypto/hash.h:89: warning: duplicate section name 'Note'
   include/crypto/hash.h:95: warning: duplicate section name 'Note'
   include/crypto/hash.h:102: warning: duplicate section name 'Note'
   include/crypto/hash.h:89: warning: duplicate section name 'Note'
   include/crypto/hash.h:95: warning: duplicate section name 'Note'
   include/crypto/hash.h:102: warning: duplicate section name 'Note'
   include/linux/gpio/driver.h:142: warning: No description found for parameter 'request_key'
   drivers/gpio/gpiolib.c:602: warning: No description found for parameter '16'
   drivers/gpio/gpiolib.c:602: warning: Excess struct member 'events' description in 'lineevent_state'
   include/linux/iio/iio.h:610: warning: No description found for parameter 'iio_dev'
   include/linux/iio/iio.h:610: warning: Excess function parameter 'indio_dev' description in 'iio_device_register'
   include/linux/iio/trigger.h:79: warning: No description found for parameter 'owner'
   fs/inode.c:1680: warning: No description found for parameter 'rcu'
   include/linux/jbd2.h:443: warning: No description found for parameter 'i_transaction'
   include/linux/jbd2.h:443: warning: No description found for parameter 'i_next_transaction'
   include/linux/jbd2.h:443: warning: No description found for parameter 'i_list'
   include/linux/jbd2.h:443: warning: No description found for parameter 'i_vfs_inode'
   include/linux/jbd2.h:443: warning: No description found for parameter 'i_flags'
   include/linux/jbd2.h:497: warning: No description found for parameter 'h_rsv_handle'
   include/linux/jbd2.h:497: warning: No description found for parameter 'h_reserved'
   include/linux/jbd2.h:497: warning: No description found for parameter 'h_type'
   include/linux/jbd2.h:497: warning: No description found for parameter 'h_line_no'
   include/linux/jbd2.h:497: warning: No description found for parameter 'h_start_jiffies'
   include/linux/jbd2.h:497: warning: No description found for parameter 'h_requested_credits'
   include/linux/jbd2.h:497: warning: No description found for parameter 'saved_alloc_context'
   include/linux/jbd2.h:1050: warning: No description found for parameter 'j_chkpt_bhs'
   include/linux/jbd2.h:1050: warning: No description found for parameter 'j_devname'
   include/linux/jbd2.h:1050: warning: No description found for parameter 'j_average_commit_time'
   include/linux/jbd2.h:1050: warning: No description found for parameter 'j_min_batch_time'
   include/linux/jbd2.h:1050: warning: No description found for parameter 'j_max_batch_time'
   include/linux/jbd2.h:1050: warning: No description found for parameter 'j_commit_callback'
   include/linux/jbd2.h:1050: warning: No description found for parameter 'j_failed_commit'
   include/linux/jbd2.h:1050: warning: No description found for parameter 'j_chksum_driver'
   include/linux/jbd2.h:1050: warning: No description found for parameter 'j_csum_seed'
   fs/jbd2/transaction.c:511: warning: No description found for parameter 'type'
   fs/jbd2/transaction.c:511: warning: No description found for parameter 'line_no'
   fs/jbd2/transaction.c:641: warning: No description found for parameter 'gfp_mask'
   include/drm/drm_drv.h:594: warning: No description found for parameter 'gem_prime_pin'
   include/drm/drm_drv.h:594: warning: No description found for parameter 'gem_prime_unpin'
   include/drm/drm_drv.h:594: warning: No description found for parameter 'gem_prime_res_obj'
   include/drm/drm_drv.h:594: warning: No description found for parameter 'gem_prime_get_sg_table'
   include/drm/drm_drv.h:594: warning: No description found for parameter 'gem_prime_import_sg_table'
   include/drm/drm_drv.h:594: warning: No description found for parameter 'gem_prime_vmap'
   include/drm/drm_drv.h:594: warning: No description found for parameter 'gem_prime_vunmap'
   include/drm/drm_drv.h:594: warning: No description found for parameter 'gem_prime_mmap'
   include/drm/drm_mode_config.h:781: warning: No description found for parameter 'modifiers_property'
   include/drm/drm_mode_config.h:781: warning: Excess struct member 'modifiers' description in 'drm_mode_config'
   include/drm/drm_plane.h:552: warning: No description found for parameter 'modifiers'
   include/drm/drm_plane.h:552: warning: No description found for parameter 'modifier_count'
   drivers/gpu/drm/drm_edid.c:4861: warning: No description found for parameter 'is_hdmi2_sink'
   drivers/gpu/drm/drm_syncobj.c:306: warning: No description found for parameter 'file_private'
   drivers/gpu/drm/drm_syncobj.c:306: warning: No description found for parameter 'syncobj'
   drivers/gpu/drm/drm_syncobj.c:306: warning: No description found for parameter 'handle'
   drivers/gpu/drm/drm_syncobj.c:307: warning: No description found for parameter 'file_private'
   drivers/gpu/drm/drm_syncobj.c:307: warning: No description found for parameter 'syncobj'
   drivers/gpu/drm/drm_syncobj.c:307: warning: No description found for parameter 'handle'
   drivers/gpu/drm/i915/i915_gem.c:541: warning: No description found for parameter 'rps_client'
   drivers/gpu/drm/i915/i915_gem.c:541: warning: Excess function parameter 'rps' description in 'i915_gem_object_wait'
   drivers/gpu/host1x/bus.c:50: warning: No description found for parameter 'driver'
   drivers/gpu/drm/tve200/tve200_drv.c:1: warning: no structured comments found
   net/core/dev.c:1707: warning: Excess function parameter 'dev' description in 'call_netdevice_notifiers_info'
   net/core/dev.c:6438: warning: No description found for parameter 'extack'
   net/core/dev.c:6461: warning: No description found for parameter 'extack'
   include/linux/netdevice.h:1937: warning: No description found for parameter 'carrier_changes'
>> include/linux/netdevice.h:1937: warning: Excess struct member 'carrier_up_count' description in 'net_device'
>> include/linux/netdevice.h:1937: warning: Excess struct member 'carrier_down_count' description in 'net_device'
   include/linux/phylink.h:56: warning: No description found for parameter '__ETHTOOL_DECLARE_LINK_MODE_MASK(advertising'
   include/linux/phylink.h:56: warning: No description found for parameter '__ETHTOOL_DECLARE_LINK_MODE_MASK(lp_advertising'
   include/linux/phylink.h:56: warning: Excess struct member 'advertising' description in 'phylink_link_state'
   include/linux/phylink.h:56: warning: Excess struct member 'lp_advertising' description in 'phylink_link_state'
   drivers/net/phy/sfp-bus.c:459: warning: No description found for parameter 'fwnode'
   drivers/net/phy/sfp-bus.c:459: warning: Excess function parameter 'np' description in 'sfp_register_upstream'
   drivers/net/phy/sfp-bus.c:459: warning: No description found for parameter 'fwnode'
   drivers/net/phy/sfp-bus.c:459: warning: Excess function parameter 'np' description in 'sfp_register_upstream'
   include/linux/rcupdate.h:571: ERROR: Unexpected indentation.
   include/linux/rcupdate.h:575: ERROR: Unexpected indentation.
   include/linux/rcupdate.h:579: WARNING: Block quote ends without a blank line; unexpected unindent.
   include/linux/rcupdate.h:581: WARNING: Block quote ends without a blank line; unexpected unindent.
   include/linux/rcupdate.h:581: WARNING: Inline literal start-string without end-string.
   kernel/time/timer.c:1251: ERROR: Unexpected indentation.
   kernel/time/timer.c:1253: ERROR: Unexpected indentation.
   kernel/time/timer.c:1254: WARNING: Block quote ends without a blank line; unexpected unindent.
   include/linux/wait.h:110: WARNING: Block quote ends without a blank line; unexpected unindent.
   include/linux/wait.h:113: ERROR: Unexpected indentation.
   include/linux/wait.h:115: WARNING: Block quote ends without a blank line; unexpected unindent.
   kernel/time/hrtimer.c:989: WARNING: Block quote ends without a blank line; unexpected unindent.
   kernel/signal.c:325: WARNING: Inline literal start-string without end-string.
   include/linux/iio/iio.h:219: ERROR: Unexpected indentation.
   include/linux/iio/iio.h:220: WARNING: Block quote ends without a blank line; unexpected unindent.
   include/linux/iio/iio.h:226: WARNING: Definition list ends without a blank line; unexpected unindent.
   drivers/ata/libata-core.c:5920: ERROR: Unknown target name: "hw".
   drivers/message/fusion/mptbase.c:5051: WARNING: Definition list ends without a blank line; unexpected unindent.
   drivers/tty/serial/serial_core.c:1899: WARNING: Definition list ends without a blank line; unexpected unindent.
   include/linux/regulator/driver.h:271: ERROR: Unknown target name: "regulator_regmap_x_voltage".
   include/linux/spi/spi.h:373: ERROR: Unexpected indentation.
   drivers/w1/w1_io.c:197: WARNING: Definition list ends without a blank line; unexpected unindent.
   net/core/dev.c:4559: ERROR: Unknown target name: "page_is".
   Documentation/trace/ftrace-uses.rst:53: WARNING: Definition list ends without a blank line; unexpected unindent.
   Documentation/trace/ftrace-uses.rst:89: WARNING: Inline emphasis start-string without end-string.
   Documentation/trace/ftrace-uses.rst:89: WARNING: Inline emphasis start-string without end-string.
   Documentation/errseq.rst:: WARNING: document isn't included in any toctree
   Documentation/trace/ftrace-uses.rst:: WARNING: document isn't included in any toctree
   Documentation/virtual/kvm/vcpu-requests.rst:: WARNING: document isn't included in any toctree
   Documentation/dev-tools/kselftest.rst:15: WARNING: Could not lex literal_block as "c". Highlighting skipped.
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 43: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 56: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 69: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 82: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 96: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 109: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 122: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 133: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 164: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 193: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 43: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 56: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 69: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 82: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 96: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 109: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 122: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 133: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 164: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 193: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 43: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 56: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 69: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 82: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 96: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 109: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 122: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 133: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 164: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 193: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 43: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 56: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 69: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 82: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 96: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 109: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 122: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 133: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 164: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 193: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 43: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 56: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 69: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 82: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 96: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 109: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 122: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 133: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 164: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 193: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 43: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 56: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 69: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 82: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 96: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 109: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 122: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 133: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 164: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.fonts.conf", line 193: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 43: Having multiple values in <test> isn't supported and may not work as expected
   Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 56: Having multiple values in <test> isn't supported and may not work as expected

vim +1937 include/linux/netdevice.h

^1da177e4 Linus Torvalds        2005-04-16  1906  
43cb76d91 Greg Kroah-Hartman    2002-04-09  1907  	struct device		dev;
0c509a6c9 Eric W. Biederman     2009-10-29  1908  	const struct attribute_group *sysfs_groups[4];
a953be53c Michael Dalton        2014-01-16  1909  	const struct attribute_group *sysfs_rx_queue_group;
38f7b870d Patrick McHardy       2007-06-13  1910  
38f7b870d Patrick McHardy       2007-06-13  1911  	const struct rtnl_link_ops *rtnl_link_ops;
f25f4e448 Peter P Waskiewicz Jr 2007-07-06  1912  
82cc1a7a5 Peter P Waskiewicz Jr 2008-03-21  1913  	/* for setting kernel sock attribute on TCP connection setup */
82cc1a7a5 Peter P Waskiewicz Jr 2008-03-21  1914  #define GSO_MAX_SIZE		65536
82cc1a7a5 Peter P Waskiewicz Jr 2008-03-21  1915  	unsigned int		gso_max_size;
30b678d84 Ben Hutchings         2012-07-30  1916  #define GSO_MAX_SEGS		65535
30b678d84 Ben Hutchings         2012-07-30  1917  	u16			gso_max_segs;
743b03a83 Eric Dumazet          2016-04-09  1918  
7a6b6f515 Jeff Kirsher          2008-11-25  1919  #ifdef CONFIG_DCB
329535432 Stephen Hemminger     2009-10-05  1920  	const struct dcbnl_rtnl_ops *dcbnl_ops;
2f90b8657 Alexander Duyck       2008-11-20  1921  #endif
4f57c087d John Fastabend        2011-01-17  1922  	u8			num_tc;
4f57c087d John Fastabend        2011-01-17  1923  	struct netdev_tc_txq	tc_to_txq[TC_MAX_QUEUE];
4f57c087d John Fastabend        2011-01-17  1924  	u8			prio_tc_map[TC_BITMASK + 1];
2f90b8657 Alexander Duyck       2008-11-20  1925  
d11ead756 Ben Hutchings         2011-11-25  1926  #if IS_ENABLED(CONFIG_FCOE)
4d288d576 Yi Zou                2009-02-27  1927  	unsigned int		fcoe_ddp_xid;
4d288d576 Yi Zou                2009-02-27  1928  #endif
86f8515f9 Daniel Borkmann       2013-12-29  1929  #if IS_ENABLED(CONFIG_CGROUP_NET_PRIO)
5bc1421e3 Neil Horman           2011-11-22  1930  	struct netprio_map __rcu *priomap;
5bc1421e3 Neil Horman           2011-11-22  1931  #endif
c1f19b51d Richard Cochran       2010-07-17  1932  	struct phy_device	*phydev;
23d3b8bfb Eric Dumazet          2012-09-05  1933  	struct lock_class_key	*qdisc_tx_busylock;
f9eb8aea2 Eric Dumazet          2016-06-06  1934  	struct lock_class_key	*qdisc_running_key;
d746d707a Anuradha Karuppiah    2015-07-14  1935  	bool			proto_down;
^1da177e4 Linus Torvalds        2005-04-16  1936  };
43cb76d91 Greg Kroah-Hartman    2002-04-09 @1937  #define to_net_dev(d) container_of(d, struct net_device, dev)
^1da177e4 Linus Torvalds        2005-04-16  1938  

:::::: The code at line 1937 was first introduced by commit
:::::: 43cb76d91ee85f579a69d42bc8efc08bac560278 Network: convert network devices to use struct device instead of class_device

:::::: TO: Greg Kroah-Hartman <gregkh@suse.de>
:::::: CC: Greg Kroah-Hartman <gregkh@suse.de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 6833 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH net-next 2/4] net: phy: sfp: Fix kernel doc warning
  2018-01-23  3:14 [PATCH net-next 0/4] Kernel doc fixes for networking Florian Fainelli
  2018-01-23  3:14 ` [PATCH net-next 1/4] net: core: Fix kernel-doc for carrier_* attributes Florian Fainelli
@ 2018-01-23  3:14 ` Florian Fainelli
  2018-01-23  3:14 ` [PATCH net-next 3/4] net: core: Fix kernel-doc for call_netdevice_notifiers_info() Florian Fainelli
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2018-01-23  3:14 UTC (permalink / raw)
  To: netdev
  Cc: Florian Fainelli, Andrew Lunn, David S. Miller, Daniel Borkmann,
	Eric Dumazet, Jakub Kicinski, Jesper Dangaard Brouer,
	Rasmus Villemoes, John Fastabend, tcharding, Ido Schimmel,
	open list

We forgot to update the kernel doc header above sfp_register_upstream()

Fixes: c19bb00070dd ("sfp: convert to fwnode")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/net/phy/sfp-bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/sfp-bus.c b/drivers/net/phy/sfp-bus.c
index bdc4bb3c8288..8961209ee949 100644
--- a/drivers/net/phy/sfp-bus.c
+++ b/drivers/net/phy/sfp-bus.c
@@ -441,7 +441,7 @@ EXPORT_SYMBOL_GPL(sfp_upstream_stop);
 
 /**
  * sfp_register_upstream() - Register the neighbouring device
- * @np: device node for the SFP bus
+ * @fwnode: firmware node for the SFP bus
  * @ndev: network device associated with the interface
  * @upstream: the upstream private data
  * @ops: the upstream's &struct sfp_upstream_ops
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH net-next 3/4] net: core: Fix kernel-doc for call_netdevice_notifiers_info()
  2018-01-23  3:14 [PATCH net-next 0/4] Kernel doc fixes for networking Florian Fainelli
  2018-01-23  3:14 ` [PATCH net-next 1/4] net: core: Fix kernel-doc for carrier_* attributes Florian Fainelli
  2018-01-23  3:14 ` [PATCH net-next 2/4] net: phy: sfp: Fix kernel doc warning Florian Fainelli
@ 2018-01-23  3:14 ` Florian Fainelli
  2018-01-23  3:14 ` [PATCH net-next 4/4] net: core: Fix kernel-doc for netdev_upper_link() Florian Fainelli
  2018-01-23 16:07 ` [PATCH net-next 0/4] Kernel doc fixes for networking David Miller
  4 siblings, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2018-01-23  3:14 UTC (permalink / raw)
  To: netdev
  Cc: Florian Fainelli, Andrew Lunn, David S. Miller, Daniel Borkmann,
	Eric Dumazet, Jakub Kicinski, Jesper Dangaard Brouer,
	Rasmus Villemoes, John Fastabend, tcharding, Ido Schimmel,
	open list

Remove the @dev comment, since we do not have a net_device argument, fixes the
following kernel doc warning: /net/core/dev.c:1707: warning: Excess function
parameter 'dev' description in 'call_netdevice_notifiers_info'

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 net/core/dev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 94435cd09072..7af0ef425ca3 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1694,7 +1694,6 @@ EXPORT_SYMBOL(unregister_netdevice_notifier);
 /**
  *	call_netdevice_notifiers_info - call all network notifier blocks
  *	@val: value passed unmodified to notifier function
- *	@dev: net_device pointer passed unmodified to notifier function
  *	@info: notifier information data
  *
  *	Call all network notifier blocks.  Parameters and return value
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH net-next 4/4] net: core: Fix kernel-doc for netdev_upper_link()
  2018-01-23  3:14 [PATCH net-next 0/4] Kernel doc fixes for networking Florian Fainelli
                   ` (2 preceding siblings ...)
  2018-01-23  3:14 ` [PATCH net-next 3/4] net: core: Fix kernel-doc for call_netdevice_notifiers_info() Florian Fainelli
@ 2018-01-23  3:14 ` Florian Fainelli
  2018-01-23 16:07 ` [PATCH net-next 0/4] Kernel doc fixes for networking David Miller
  4 siblings, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2018-01-23  3:14 UTC (permalink / raw)
  To: netdev
  Cc: Florian Fainelli, Andrew Lunn, David S. Miller, Daniel Borkmann,
	Eric Dumazet, Jakub Kicinski, Jesper Dangaard Brouer,
	Rasmus Villemoes, John Fastabend, tcharding, Ido Schimmel,
	open list

Fixes the following warnings:
./net/core/dev.c:6438: warning: No description found for parameter 'extack'
./net/core/dev.c:6461: warning: No description found for parameter 'extack'

Fixes: 42ab19ee9029 ("net: Add extack to upper device linking")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 net/core/dev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/core/dev.c b/net/core/dev.c
index 7af0ef425ca3..77795f66c246 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6424,6 +6424,7 @@ static int __netdev_upper_dev_link(struct net_device *dev,
  * netdev_upper_dev_link - Add a link to the upper device
  * @dev: device
  * @upper_dev: new upper device
+ * @extack: netlink extended ack
  *
  * Adds a link to device which is upper to this one. The caller must hold
  * the RTNL lock. On a failure a negative errno code is returned.
@@ -6445,6 +6446,7 @@ EXPORT_SYMBOL(netdev_upper_dev_link);
  * @upper_dev: new upper device
  * @upper_priv: upper device private
  * @upper_info: upper info to be passed down via notifier
+ * @extack: netlink extended ack
  *
  * Adds a link to device which is upper to this one. In this case, only
  * one master upper device can be linked, although other non-master devices
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH net-next 0/4] Kernel doc fixes for networking
  2018-01-23  3:14 [PATCH net-next 0/4] Kernel doc fixes for networking Florian Fainelli
                   ` (3 preceding siblings ...)
  2018-01-23  3:14 ` [PATCH net-next 4/4] net: core: Fix kernel-doc for netdev_upper_link() Florian Fainelli
@ 2018-01-23 16:07 ` David Miller
  4 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2018-01-23 16:07 UTC (permalink / raw)
  To: f.fainelli
  Cc: netdev, andrew, daniel, edumazet, jakub.kicinski, brouer, linux,
	john.fastabend, me, idosch, linux-kernel

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Mon, 22 Jan 2018 19:14:24 -0800

> This patch series fixes kernel doc warnings found while running make htmldocs
> pertaining to the networking subsystem. There is a finaly set of warnings due
> to PHYLINK which I have not been able to resolve yet.
> 
> The last patch could thereoteically be applied to 'net' since the commit
> referenced by the Fixes: tag is present in v4.15-rcX.

Series applied to net-next, thanks Florian.

I'll defer on the 'net' one, it's already really late in the game and only
super critical fixes should be submitted there at this point.

Thanks.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-01-25  0:25 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-23  3:14 [PATCH net-next 0/4] Kernel doc fixes for networking Florian Fainelli
2018-01-23  3:14 ` [PATCH net-next 1/4] net: core: Fix kernel-doc for carrier_* attributes Florian Fainelli
2018-01-25  0:25   ` kbuild test robot
2018-01-23  3:14 ` [PATCH net-next 2/4] net: phy: sfp: Fix kernel doc warning Florian Fainelli
2018-01-23  3:14 ` [PATCH net-next 3/4] net: core: Fix kernel-doc for call_netdevice_notifiers_info() Florian Fainelli
2018-01-23  3:14 ` [PATCH net-next 4/4] net: core: Fix kernel-doc for netdev_upper_link() Florian Fainelli
2018-01-23 16:07 ` [PATCH net-next 0/4] Kernel doc fixes for networking David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).