From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH bpf] bpf: test_maps: cleanup sockmaps when test ends Date: Mon, 22 Jan 2018 21:01:09 -0800 Message-ID: <20180123050108.fcmh4phzcclxer2f@ast-mbp> References: <20180123043044.2144-1-bhole_prashant_q7@lab.ntt.co.jp> <20180123043839.kg6ffx2q7iezuswy@ast-mbp> <902e1164-d4a3-6fae-1f29-8b7433a18710@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S . Miller" , Alexei Starovoitov , Daniel Borkmann , Shuah Khan , netdev@vger.kernel.org, John Fastabend To: Prashant Bhole Return-path: Received: from mail-pf0-f171.google.com ([209.85.192.171]:45708 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbeAWFBN (ORCPT ); Tue, 23 Jan 2018 00:01:13 -0500 Received: by mail-pf0-f171.google.com with SMTP id a88so8865583pfe.12 for ; Mon, 22 Jan 2018 21:01:13 -0800 (PST) Content-Disposition: inline In-Reply-To: <902e1164-d4a3-6fae-1f29-8b7433a18710@lab.ntt.co.jp> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jan 23, 2018 at 01:55:30PM +0900, Prashant Bhole wrote: > > > On 1/23/2018 1:38 PM, Alexei Starovoitov wrote: > > On Tue, Jan 23, 2018 at 01:30:44PM +0900, Prashant Bhole wrote: > > > Bug: BPF programs and maps related to sockmaps test exist in > > > memory even after test_maps ends > > > > > > This patch fixes it by empyting sockmaps when test ends. > > > > > > Fixes: 6f6d33f3b3d0f ("bpf: selftests add sockmap tests") > > > Signed-off-by: Prashant Bhole > > > > that's a fine workaround and I'm planning to apply this patch > > to bpf-next, but it's not a fix. The sockmap should have cleaned > > itself up. > > Ok. Do I need to re-submit it targeted to -bpf-next and without fixes tag? No need. It's fine.