From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: [PATCH net] i40e: flower: check if TC offload is enabled on a netdev Date: Tue, 23 Jan 2018 00:08:40 -0800 Message-ID: <20180123080840.768-1-jakub.kicinski@netronome.com> Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, jeffrey.t.kirsher@intel.com, amritha.nambiar@intel.com, jiri@resnulli.us, alexander.h.duyck@intel.com, Jakub Kicinski To: davem@davemloft.net Return-path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:35980 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbeAWII6 (ORCPT ); Tue, 23 Jan 2018 03:08:58 -0500 Received: by mail-pg0-f68.google.com with SMTP id k68so9135161pga.3 for ; Tue, 23 Jan 2018 00:08:57 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: Since TC block changes drivers are required to check if the TC hw offload flag is set on the interface themselves. Fixes: 2f4b411a3d67 ("i40e: Enable cloud filters via tc-flower") Fixes: 44ae12a768b7 ("net: sched: move the can_offload check from binding phase to rule insertion phase") Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 42dcaefc4c19..af792112a2d3 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -7505,6 +7505,8 @@ static int i40e_setup_tc_cls_flower(struct i40e_netdev_priv *np, { struct i40e_vsi *vsi = np->vsi; + if (!tc_can_offload(vsi->netdev)) + return -EOPNOTSUPP; if (cls_flower->common.chain_index) return -EOPNOTSUPP; -- 2.15.1