From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Cc: john.fastabend@gmail.com, Cong Wang <xiyou.wangcong@gmail.com>
Subject: [Patch net-next v2 3/3] net_sched: implement ->change_tx_queue_len() for pfifo_fast
Date: Tue, 23 Jan 2018 10:18:59 -0800 [thread overview]
Message-ID: <20180123181859.18583-4-xiyou.wangcong@gmail.com> (raw)
In-Reply-To: <20180123181859.18583-1-xiyou.wangcong@gmail.com>
pfifo_fast used to drop based on qdisc_dev(qdisc)->tx_queue_len,
so we have to resize skb array when we change tx_queue_len.
Other qdiscs which read tx_queue_len are fine because they
all save it to sch->limit or somewhere else in qdisc during init.
They don't have to implement this, it is nicer if they do so
that users don't have to re-configure qdisc after changing
tx_queue_len.
Cc: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
---
net/sched/sch_generic.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
index 08f9fa27e06e..d7b82c379617 100644
--- a/net/sched/sch_generic.c
+++ b/net/sched/sch_generic.c
@@ -763,6 +763,22 @@ static void pfifo_fast_destroy(struct Qdisc *sch)
}
}
+static int pfifo_fast_change_tx_queue_len(struct Qdisc *sch, unsigned int new_len)
+{
+ struct pfifo_fast_priv *priv = qdisc_priv(sch);
+ int ret = 0, prio;
+
+ for (prio = 0; prio < PFIFO_FAST_BANDS; prio++) {
+ struct skb_array *q = band2list(priv, prio);
+
+ ret = skb_array_resize(q, new_len, GFP_KERNEL);
+ if (ret)
+ break;
+ }
+
+ return ret;
+}
+
struct Qdisc_ops pfifo_fast_ops __read_mostly = {
.id = "pfifo_fast",
.priv_size = sizeof(struct pfifo_fast_priv),
@@ -773,6 +789,7 @@ struct Qdisc_ops pfifo_fast_ops __read_mostly = {
.destroy = pfifo_fast_destroy,
.reset = pfifo_fast_reset,
.dump = pfifo_fast_dump,
+ .change_tx_queue_len = pfifo_fast_change_tx_queue_len,
.owner = THIS_MODULE,
.static_flags = TCQ_F_NOLOCK | TCQ_F_CPUSTATS,
};
--
2.13.0
next prev parent reply other threads:[~2018-01-23 18:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 18:18 [Patch net-next v2 0/3] net_sched: reflect tx_queue_len change for pfifo_fast Cong Wang
2018-01-23 18:18 ` [Patch net-next v2 1/3] net: introduce helper dev_change_tx_queue_len() Cong Wang
2018-01-23 18:18 ` [Patch net-next v2 2/3] net_sched: plug in qdisc ops change_tx_queue_len Cong Wang
2018-01-25 0:05 ` John Fastabend
2018-01-25 22:21 ` Cong Wang
2018-01-23 18:18 ` Cong Wang [this message]
2018-01-24 21:51 ` [Patch net-next v2 0/3] net_sched: reflect tx_queue_len change for pfifo_fast David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123181859.18583-4-xiyou.wangcong@gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).