From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 02/12] net: sched: prepare for reimplementation of tc_cls_common_offload_init() Date: Wed, 24 Jan 2018 10:37:59 -0500 (EST) Message-ID: <20180124.103759.964594136701466505.davem@davemloft.net> References: <20180124024608.11328-1-jakub.kicinski@netronome.com> <20180124024608.11328-3-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: dsahern@gmail.com, daniel@iogearbox.net, john.fastabend@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, oss-drivers@netronome.com, aring@mojatatu.com To: jakub.kicinski@netronome.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:45330 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933953AbeAXPiB (ORCPT ); Wed, 24 Jan 2018 10:38:01 -0500 In-Reply-To: <20180124024608.11328-3-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Date: Tue, 23 Jan 2018 18:45:58 -0800 > Rename tc_cls_common_offload_init() to tc_cls_common_offload_init__() > and add a new implementation which also takes flags argument. We will > only set extack if flags indicate that offload is forced (skip_sw) > otherwise driver errors should be ignored, as they don't influence > the overall filter installation. > > Note that we need the tc_skip_hw() helper for new version, therefore > it is added later in the file. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Simon Horman Just give the old function a name which makes it's transient purpose clear rather than this weird foo__() convention. Something like tc_cls_common_offload_init_compat() or even tc_cls_common_offload_init_deprecated(). Then people can say "oh, that is serving as a temporary compat function until everyone is converted, then it is deleted" Thanks.