From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, idosch@mellanox.com, mlxsw@mellanox.com
Subject: Re: [patch net] mlxsw: spectrum_router: Don't log an error on missing neighbor
Date: Wed, 24 Jan 2018 10:59:04 -0500 (EST) [thread overview]
Message-ID: <20180124.105904.919163369493094197.davem@davemloft.net> (raw)
In-Reply-To: <20180124090209.7740-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 24 Jan 2018 10:02:09 +0100
> From: Yuval Mintz <yuvalm@mellanox.com>
>
> Driver periodically samples all neighbors configured in device
> in order to update the kernel regarding their state. When finding
> an entry configured in HW that doesn't show in neigh_lookup()
> driver logs an error message.
> This introduces a race when removing multiple neighbors -
> it's possible that a given entry would still be configured in HW
> as its removal is still being processed but is already removed
> from the kernel's neighbor tables.
>
> Simply remove the error message and gracefully accept such events.
>
> Fixes: c723c735fa6b ("mlxsw: spectrum_router: Periodically update the kernel's neigh table")
> Fixes: 60f040ca11b9 ("mlxsw: spectrum_router: Periodically dump active IPv6 neighbours")
> Signed-off-by: Yuval Mintz <yuvalm@mellanox.com>
> Reviewed-by: Ido Schimmel <idosch@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2018-01-24 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 9:02 [patch net] mlxsw: spectrum_router: Don't log an error on missing neighbor Jiri Pirko
2018-01-24 15:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124.105904.919163369493094197.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).