From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch net] mlxsw: spectrum_router: Don't log an error on missing neighbor Date: Wed, 24 Jan 2018 10:59:04 -0500 (EST) Message-ID: <20180124.105904.919163369493094197.davem@davemloft.net> References: <20180124090209.7740-1-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, idosch@mellanox.com, mlxsw@mellanox.com To: jiri@resnulli.us Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:45684 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933953AbeAXP7F (ORCPT ); Wed, 24 Jan 2018 10:59:05 -0500 In-Reply-To: <20180124090209.7740-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: From: Jiri Pirko Date: Wed, 24 Jan 2018 10:02:09 +0100 > From: Yuval Mintz > > Driver periodically samples all neighbors configured in device > in order to update the kernel regarding their state. When finding > an entry configured in HW that doesn't show in neigh_lookup() > driver logs an error message. > This introduces a race when removing multiple neighbors - > it's possible that a given entry would still be configured in HW > as its removal is still being processed but is already removed > from the kernel's neighbor tables. > > Simply remove the error message and gracefully accept such events. > > Fixes: c723c735fa6b ("mlxsw: spectrum_router: Periodically update the kernel's neigh table") > Fixes: 60f040ca11b9 ("mlxsw: spectrum_router: Periodically dump active IPv6 neighbours") > Signed-off-by: Yuval Mintz > Reviewed-by: Ido Schimmel > Signed-off-by: Jiri Pirko Applied and queued up for -stable, thanks.