From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com
Subject: Re: [net-next 0/8][pull request] 1GbE Intel Wired LAN Driver Updates 2018-01-24
Date: Wed, 24 Jan 2018 16:10:37 -0500 (EST) [thread overview]
Message-ID: <20180124.161037.993176469959335207.davem@davemloft.net> (raw)
In-Reply-To: <20180124205520.5811-1-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 24 Jan 2018 12:55:12 -0800
> This series contains updates to igb and e1000e only.
Pulled, however:
> Corinna Vinschen implements the ability to set the VF MAC to
> 00:00:00:00:00:00 via RTM_SETLINK on the PF, to prevent receiving
> "invlaid argument" when libvirt attempts to restore the MAC address back
> to its original state of 00:00:00:00:00:00.
This is really a mess and the wrong way to go about this.
No interface, even a VF, should come up or ever have an invalid
MAC addres like all-zeros. That's the fundamental problem and
once you fix that all of this other crazy logic and workarounds
no longer become necessary.
Whatever it takes, just do it. We can even come up with a global
MAC address range that on a Linux system is reserved for VFs to
come up with.
Thanks.
next prev parent reply other threads:[~2018-01-24 21:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 20:55 [net-next 0/8][pull request] 1GbE Intel Wired LAN Driver Updates 2018-01-24 Jeff Kirsher
2018-01-24 20:55 ` [net-next 1/8] igb: Allow to remove administratively set MAC on VFs Jeff Kirsher
2018-01-24 20:55 ` [net-next 2/8] igb: add function to get maximum RSS queues Jeff Kirsher
2018-01-24 20:55 ` [net-next 3/8] e1000e: Set HTHRESH when PTHRESH is used Jeff Kirsher
2018-01-24 20:55 ` [net-next 4/8] igb: Clarify idleslope config constraints Jeff Kirsher
2018-01-24 20:55 ` [net-next 5/8] e1000e: Alert the user that C-states will be disabled by enabling jumbo frames Jeff Kirsher
2018-01-24 20:55 ` [net-next 6/8] igb: Free IRQs when device is hotplugged Jeff Kirsher
2018-01-24 20:55 ` [net-next 7/8] igb: Delete an error message for a failed memory allocation in igb_enable_sriov() Jeff Kirsher
2018-01-24 20:55 ` [net-next 8/8] igb: Clear TXSTMP when ptp_tx_work() is timeout Jeff Kirsher
2018-01-24 21:10 ` David Miller [this message]
2018-01-25 2:29 ` [net-next 0/8][pull request] 1GbE Intel Wired LAN Driver Updates 2018-01-24 Alexander Duyck
2018-01-29 16:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124.161037.993176469959335207.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).