From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [net-next 0/8][pull request] 1GbE Intel Wired LAN Driver
 Updates 2018-01-24
Date: Wed, 24 Jan 2018 16:10:37 -0500 (EST)
Message-ID: <20180124.161037.993176469959335207.davem@davemloft.net>
References: <20180124205520.5811-1-jeffrey.t.kirsher@intel.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
        jogreene@redhat.com
To: jeffrey.t.kirsher@intel.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:50134 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932238AbeAXVKj (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 24 Jan 2018 16:10:39 -0500
In-Reply-To: <20180124205520.5811-1-jeffrey.t.kirsher@intel.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 24 Jan 2018 12:55:12 -0800

> This series contains updates to igb and e1000e only.

Pulled, however:

> Corinna Vinschen implements the ability to set the VF MAC to
> 00:00:00:00:00:00 via RTM_SETLINK on the PF, to prevent receiving
> "invlaid argument" when libvirt attempts to restore the MAC address back
> to its original state of 00:00:00:00:00:00.

This is really a mess and the wrong way to go about this.

No interface, even a VF, should come up or ever have an invalid
MAC addres like all-zeros.  That's the fundamental problem and
once you fix that all of this other crazy logic and workarounds
no longer become necessary.

Whatever it takes, just do it.  We can even come up with a global
MAC address range that on a Linux system is reserved for VFs to
come up with.

Thanks.