From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 1/2] vhost: use mutex_lock_nested() in vhost_dev_lock_vqs() Date: Wed, 24 Jan 2018 16:38:30 -0500 (EST) Message-ID: <20180124.163830.2180124252515802160.davem@davemloft.net> References: <1516699646-7321-1-git-send-email-jasowang@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: mst@redhat.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org To: jasowang@redhat.com Return-path: In-Reply-To: <1516699646-7321-1-git-send-email-jasowang@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Jason Wang Date: Tue, 23 Jan 2018 17:27:25 +0800 > We used to call mutex_lock() in vhost_dev_lock_vqs() which tries to > hold mutexes of all virtqueues. This may confuse lockdep to report a > possible deadlock because of trying to hold locks belong to same > class. Switch to use mutex_lock_nested() to avoid false positive. > > Fixes: 6b1e6cc7855b0 ("vhost: new device IOTLB API") > Reported-by: syzbot+dbb7c1161485e61b0241@syzkaller.appspotmail.com > Signed-off-by: Jason Wang Michael, I see you ACK'd this, meaning that you're OK with these two fixes going via my net tree? Thanks.