From: David Miller <davem@davemloft.net>
To: dsahern@gmail.com
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org,
idosch@mellanox.com, roopa@cumulusnetworks.com
Subject: Re: [PATCH net-next 3/3] net/ipv6: Add support for onlink flag
Date: Wed, 24 Jan 2018 17:53:42 -0500 (EST) [thread overview]
Message-ID: <20180124.175342.81540700258640658.davem@davemloft.net> (raw)
In-Reply-To: <15b326c5-a3e5-14a2-2034-072f2d2794fb@gmail.com>
From: David Ahern <dsahern@gmail.com>
Date: Wed, 24 Jan 2018 15:08:39 -0700
> On 1/23/18 8:00 PM, David Ahern wrote:
>> + tbid = l3mdev_fib_table(dev) ? : RT_TABLE_MAIN;
>> + if (cfg->fc_table && cfg->fc_table != tbid) {
>> + NL_SET_ERR_MSG(extack,
>> + "Table id mismatch between given table and device");
>> + return -EINVAL;
>> + }
>> +
>> + cfg->fc_table = tbid;
>> +
>> + return 0;
>
> This table check is too restrictive for some PBR cases.
>
> Dave: please drop this set; I'll repost.
Ok.
prev parent reply other threads:[~2018-01-24 22:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 3:00 [PATCH net-next 0/3] net/ipv6: Add support for ONLINK flag David Ahern
2018-01-24 3:00 ` [PATCH net-next 1/3] net/ipv6: Move gateway validation into helper David Ahern
2018-01-24 3:00 ` [PATCH net-next 2/3] net/ipv6: Add flags arg to ip6_nh_lookup_table David Ahern
2018-01-24 3:00 ` [PATCH net-next 3/3] net/ipv6: Add support for onlink flag David Ahern
2018-01-24 22:08 ` David Ahern
2018-01-24 22:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124.175342.81540700258640658.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).