From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [net-next 0/7][pull request] 100GbE Intel Wired LAN Driver Updates 2018-01-24 Date: Wed, 24 Jan 2018 18:02:36 -0500 (EST) Message-ID: <20180124.180236.687538947909157455.davem@davemloft.net> References: <20180124224546.21185-1-jeffrey.t.kirsher@intel.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com To: jeffrey.t.kirsher@intel.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:51754 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932294AbeAXXCi (ORCPT ); Wed, 24 Jan 2018 18:02:38 -0500 In-Reply-To: <20180124224546.21185-1-jeffrey.t.kirsher@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jeff Kirsher Date: Wed, 24 Jan 2018 14:45:39 -0800 > This series contains updates to fm10k only. > > Alex fixes MACVLAN offload for fm10k, where we were not seeing unicast > packets being received because we did not correctly configure the > default VLAN ID for the port and defaulting to 0. > > Jake cleans up unnecessary parenthesis in a couple of "if" statements. > Fixed the driver to stop adding VLAN 0 into the VLAN table, since it > would cause the VLAN table to be inconsistent between the PF and VF. > Also fixed an issue where we were assuming that VLAN 1 is enabled when > the default VLAN ID is not set, so resolve by not requesting any filters > for the default_vid if it has not yet been assigned. > > Ngai fixes an issue which was generating a dmesg regarding unbale to > kill a particular VLAN ID for the device. This is due to > ndo_vlan_rx_kill_vid() exits with an error and the handler for this ndo > is fm10k_update_vid() which exits prematurely under PF VLAN management. > So to resolve, we must check the VLAN update action type before exiting > fm10k_update_vid(), and act appropriately based on the action type. > Also corrected code comment typos. Looks good, pulled, thanks Jeff.