From: David Miller <davem@davemloft.net>
To: ivan@de.ibm.com
Cc: chunkeey@googlemail.com, robh@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] net/ibm/emac: wrong bit is used for STA control register write
Date: Wed, 24 Jan 2018 18:11:26 -0500 (EST) [thread overview]
Message-ID: <20180124.181126.1573479768859874669.davem@davemloft.net> (raw)
In-Reply-To: <20180124125325.56824-2-ivan@de.ibm.com>
From: Ivan Mikhaylov <ivan@de.ibm.com>
Date: Wed, 24 Jan 2018 15:53:25 +0300
> STA control register has areas of mode and opcodes for opeations. 18 bit is
> using for mode selection, where 0 is old MIO/MDIO access method and 1 is
> indirect access mode. 19-20 bits are using for setting up read/write
> operation(STA opcodes). In current state 'read' is set into old MIO/MDIO mode
> with 19 bit and write operation is set into 18 bit which is mode selection,
> not a write operation. To correlate write with read we set it into 20 bit.
> All those bit operations are MSB 0 based.
>
> Signed-off-by: Ivan Mikhaylov <ivan@de.ibm.com>
Applied.
next prev parent reply other threads:[~2018-01-24 23:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 12:53 [PATCH v2 2/2] net/ibm/emac: wrong bit is used for STA control register write Ivan Mikhaylov
2018-01-24 23:11 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-23 16:48 Ivan Mikhaylov
2018-01-23 16:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124.181126.1573479768859874669.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chunkeey@googlemail.com \
--cc=ivan@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).