From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2] tc/lexer: let quotes actually start strings Date: Wed, 24 Jan 2018 08:51:48 -0800 Message-ID: <20180124085148.0cc2cefe@xeon-e3> References: <20180122105346.15367-1-w.bumiller@proxmox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Wolfgang Bumiller Return-path: Received: from mail-pg0-f48.google.com ([74.125.83.48]:40828 "EHLO mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934194AbeAXQvv (ORCPT ); Wed, 24 Jan 2018 11:51:51 -0500 Received: by mail-pg0-f48.google.com with SMTP id g16so3093415pgn.7 for ; Wed, 24 Jan 2018 08:51:51 -0800 (PST) In-Reply-To: <20180122105346.15367-1-w.bumiller@proxmox.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 22 Jan 2018 11:53:46 +0100 Wolfgang Bumiller wrote: > The lexer will go with the longest match, so previously > the starting double quotes of a string would be swallowed by > the [^ \t\r\n()]+ pattern leaving the user no way to > actually use strings with escape sequences. > Fix this by not allowing this case to start with double > quotes. > > Signed-off-by: Wolfgang Bumiller Looks good, applied. Don't think ematch is that widely used; or someone would have noticed.