From: Phil Sutter <phil@nwl.cc>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute PATCH] ip-route: Propagate errors from parse_one_nh()
Date: Wed, 24 Jan 2018 12:08:56 +0100 [thread overview]
Message-ID: <20180124110856.GG1008@orbyte.nwl.cc> (raw)
In-Reply-To: <20180123144442.1500f35a@xeon-e3>
On Tue, Jan 23, 2018 at 02:44:42PM -0800, Stephen Hemminger wrote:
[...]
> Also, it looks like read_family converts any address family it doesn't know about to unspec
> that is stupid behavior as well.
I had a closer look and it is the best thing it could do. In all but one
cases, the function is called to parse an optional family spec so
parsing failure is expected behaviour.
Cheers, Phil
prev parent reply other threads:[~2018-01-24 11:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 16:40 [iproute PATCH] ip-route: Propagate errors from parse_one_nh() Phil Sutter
2018-01-23 22:44 ` Stephen Hemminger
2018-01-24 9:19 ` Phil Sutter
2018-01-24 15:44 ` Stephen Hemminger
2018-02-08 13:26 ` Élie Bouttier
2018-02-08 14:11 ` Phil Sutter
2018-01-24 11:08 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124110856.GG1008@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).