From mboxrd@z Thu Jan  1 00:00:00 1970
From: Phil Sutter <phil@nwl.cc>
Subject: Re: [iproute PATCH] ip-route: Propagate errors from parse_one_nh()
Date: Wed, 24 Jan 2018 12:08:56 +0100
Message-ID: <20180124110856.GG1008@orbyte.nwl.cc>
References: <20180123164047.28661-1-phil@nwl.cc>
 <20180123144442.1500f35a@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from orbyte.nwl.cc ([151.80.46.58]:40692 "EHLO orbyte.nwl.cc"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933062AbeAXLI6 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 24 Jan 2018 06:08:58 -0500
Content-Disposition: inline
In-Reply-To: <20180123144442.1500f35a@xeon-e3>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Jan 23, 2018 at 02:44:42PM -0800, Stephen Hemminger wrote:
[...]
> Also, it looks like read_family converts any address family it doesn't know about to unspec
> that is stupid behavior as well.

I had a closer look and it is the best thing it could do. In all but one
cases, the function is called to parse an optional family spec so
parsing failure is expected behaviour.

Cheers, Phil