From: Ido Schimmel <idosch@idosch.org>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org, idosch@mellanox.com
Subject: Re: [PATCH net-next] net/ipv6: Do not allow route add with a device that is down
Date: Wed, 24 Jan 2018 14:48:29 +0200 [thread overview]
Message-ID: <20180124124829.GA31174@splinter.mtl.com> (raw)
In-Reply-To: <20180124031343.22927-1-dsahern@gmail.com>
On Tue, Jan 23, 2018 at 07:13:43PM -0800, David Ahern wrote:
> IPv6 allows routes to be installed when the device is not up (admin up).
> Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really
> there is no reason for IPv6 to allow it, so check the flags and deny if
> device is admin down.
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
I figured people might complain if I change that, but I obviously prefer
to have it like IPv4. Agree with Roopa about the error code.
Thanks
prev parent reply other threads:[~2018-01-24 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 3:13 [PATCH net-next] net/ipv6: Do not allow route add with a device that is down David Ahern
2018-01-24 5:24 ` Roopa Prabhu
2018-01-24 12:48 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124124829.GA31174@splinter.mtl.com \
--to=idosch@idosch.org \
--cc=dsahern@gmail.com \
--cc=idosch@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).