From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Schimmel Subject: Re: [PATCH net-next] net/ipv6: Do not allow route add with a device that is down Date: Wed, 24 Jan 2018 14:48:29 +0200 Message-ID: <20180124124829.GA31174@splinter.mtl.com> References: <20180124031343.22927-1-dsahern@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org, idosch@mellanox.com To: David Ahern Return-path: Received: from out4-smtp.messagingengine.com ([66.111.4.28]:59487 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933397AbeAXMsd (ORCPT ); Wed, 24 Jan 2018 07:48:33 -0500 Content-Disposition: inline In-Reply-To: <20180124031343.22927-1-dsahern@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jan 23, 2018 at 07:13:43PM -0800, David Ahern wrote: > IPv6 allows routes to be installed when the device is not up (admin up). > Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really > there is no reason for IPv6 to allow it, so check the flags and deny if > device is admin down. > > Signed-off-by: David Ahern I figured people might complain if I change that, but I obviously prefer to have it like IPv4. Agree with Roopa about the error code. Thanks