From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH] cls_flower: check if filter is in HW before calling
 fl_hw_destroy_filter()
Date: Wed, 24 Jan 2018 17:07:07 +0100
Message-ID: <20180124160707.GH2234@nanopsycho>
References: <1516794175-5679-1-git-send-email-sathya.perla@broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org
To: Sathya Perla <sathya.perla@broadcom.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wm0-f52.google.com ([74.125.82.52]:42874 "EHLO
        mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934021AbeAXQHJ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 24 Jan 2018 11:07:09 -0500
Received: by mail-wm0-f52.google.com with SMTP id r71so9499667wmd.1
        for <netdev@vger.kernel.org>; Wed, 24 Jan 2018 08:07:08 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1516794175-5679-1-git-send-email-sathya.perla@broadcom.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Wed, Jan 24, 2018 at 12:42:55PM CET, sathya.perla@broadcom.com wrote:
>When a filter cannot be added in HW (i.e, fl_hw_replace_filter() returns
>error), the TCA_CLS_FLAGS_IN_HW flag is not set in the filter flags.
>
>This flag (via tc_in_hw()) must be checked before issuing the call
>to delete a filter in HW (fl_hw_destroy_filter()) and before issuing the
>call to query stats (fl_hw_update_stats()).
>
>Signed-off-by: Sathya Perla <sathya.perla@broadcom.com>

1) You have to indicate what tree you aim this to be applied on:
   [patch net] or [patch net-next]
2) Please provided a "Fixes" line
3) Please use scripts/get_maintainer.pl to get the people to cc
4) Please aim the fix not only to cls_flower, but to other cls as well.

otherwise the patch looks ok.