netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Ngai-Mint Kwan <ngai-mint.kwan@intel.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	jogreene@redhat.com, Jacob Keller <jacob.e.keller@gmail.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 7/7] fm10k: clarify action when updating the VLAN table
Date: Wed, 24 Jan 2018 14:45:46 -0800	[thread overview]
Message-ID: <20180124224546.21185-8-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20180124224546.21185-1-jeffrey.t.kirsher@intel.com>

From: Ngai-Mint Kwan <ngai-mint.kwan@intel.com>

Clarify the comment for when entering promiscuous mode that we update
the VLAN table. Add a comment distinguishing the case where we're
exiting promiscuous mode and need to clear the entire VLAN table.

Signed-off-by: Ngai-Mint Kwan <ngai-mint.kwan@intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@gmail.com>
Tested-by: Krishneil Singh <krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
index 4c9d8e52415b..a38ae5c54da3 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
@@ -1165,10 +1165,12 @@ static void fm10k_set_rx_mode(struct net_device *dev)
 
 	/* update xcast mode first, but only if it changed */
 	if (interface->xcast_mode != xcast_mode) {
-		/* update VLAN table */
+		/* update VLAN table when entering promiscuous mode */
 		if (xcast_mode == FM10K_XCAST_MODE_PROMISC)
 			fm10k_queue_vlan_request(interface, FM10K_VLAN_ALL,
 						 0, true);
+
+		/* clear VLAN table when exiting promiscuous mode */
 		if (interface->xcast_mode == FM10K_XCAST_MODE_PROMISC)
 			fm10k_clear_unused_vlans(interface);
 
-- 
2.14.3

  parent reply	other threads:[~2018-01-24 22:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24 22:45 [net-next 0/7][pull request] 100GbE Intel Wired LAN Driver Updates 2018-01-24 Jeff Kirsher
2018-01-24 22:45 ` [net-next 1/7] fm10k: Fix configuration for macvlan offload Jeff Kirsher
2018-01-24 22:45 ` [net-next 2/7] fm10k: cleanup unnecessary parenthesis in fm10k_iov.c Jeff Kirsher
2018-01-31 11:34   ` Joe Perches
2018-01-31 22:40     ` Keller, Jacob E
2018-01-24 22:45 ` [net-next 3/7] fm10k: fix "failed to kill vid" message for VF Jeff Kirsher
2018-01-24 22:45 ` [net-next 4/7] fm10k: stop adding VLAN 0 to the VLAN table Jeff Kirsher
2018-01-24 22:45 ` [net-next 5/7] fm10k: don't assume VLAN 1 is enabled Jeff Kirsher
2018-01-24 22:45 ` [net-next 6/7] fm10k: correct typo in fm10k_pf.c Jeff Kirsher
2018-01-24 22:45 ` Jeff Kirsher [this message]
2018-01-24 23:02 ` [net-next 0/7][pull request] 100GbE Intel Wired LAN Driver Updates 2018-01-24 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180124224546.21185-8-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=jacob.e.keller@gmail.com \
    --cc=jogreene@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=ngai-mint.kwan@intel.com \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).