From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: [PATCH v3 net-next] net/ipv6: Do not allow route add with a device that is down Date: Wed, 24 Jan 2018 19:45:29 -0800 Message-ID: <20180125034529.9987-1-dsahern@gmail.com> Cc: David Ahern To: netdev@vger.kernel.org Return-path: Received: from mail-pf0-f194.google.com ([209.85.192.194]:43821 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933198AbeAYDpf (ORCPT ); Wed, 24 Jan 2018 22:45:35 -0500 Received: by mail-pf0-f194.google.com with SMTP id y26so4830111pfi.10 for ; Wed, 24 Jan 2018 19:45:35 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: IPv6 allows routes to be installed when the device is not up (admin up). Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really there is no reason for IPv6 to allow it, so check the flags and deny if device is admin down. Signed-off-by: David Ahern --- v3 - moved err=-ENETDOWN under the if check per Eric's request - left the up check using dev->flags for consistency with IPv4 and that it is used more often in ipv4 and ivp6 code than netif_running v2 - missed setting err to -ENETDOWN (thanks for catching that Roopa) net/ipv6/route.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index f85da2f1e729..aa4411c81e7e 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2734,6 +2734,12 @@ static struct rt6_info *ip6_route_info_create(struct fib6_config *cfg, if (!dev) goto out; + if (!(dev->flags & IFF_UP)) { + NL_SET_ERR_MSG(extack, "Nexthop device is not up"); + err = -ENETDOWN; + goto out; + } + if (!ipv6_addr_any(&cfg->fc_prefsrc)) { if (!ipv6_chk_addr(net, &cfg->fc_prefsrc, dev, 0)) { NL_SET_ERR_MSG(extack, "Invalid source address"); -- 2.11.0