netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
To: David Miller <davem@davemloft.net>
Cc: sgoutham@cavium.com, rric@kernel.org,
	linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Vadim.Lomovtsev@cavium.com,
	dnelson@redhat.com
Subject: Re: [PATCH v3] net: ethernet: cavium: Correct Cavium Thunderx NIC module and driver names
Date: Thu, 25 Jan 2018 03:11:32 -0800	[thread overview]
Message-ID: <20180125111132.GA6458@localhost.localdomain> (raw)
In-Reply-To: <20180124.162737.1427515957453841771.davem@davemloft.net>

On Wed, Jan 24, 2018 at 04:27:37PM -0500, David Miller wrote:
> From: Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
> Date: Mon, 22 Jan 2018 06:13:27 -0800
> 
> > From: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
> > 
> > It was found that ethtool provides unexisting module name while
> > it queries the specified network device for associated driver
> > information. Then user tries to unload that module by provided
> > module name and fails.
> > 
> > This happens because ethtool reads value of DRV_NAME macro,
> > while module name is defined at the driver's Makefile.
> > 
> > This patch is to correct Cavium CN88xx Thunder NIC driver modules
> > names 'nicvf' to 'thunder_nicvf' and 'nicpf' to 'thunder_nicpf' along
> > with updating DRV_NAME macro values accordingly.
> > 
> > Signed-off-by: Dean Nelson <dnelson@redhat.com>
> > Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
> 
> Once your driver has been deployed in a real upstream release you
> should never change the driver module name.
> 
> So if you want to fix things, you'll have to fix them the other
> way around, by not changing the module name but changing the
> strings that ethtool ends up with instead.
> 
> Thank you.

Ok, understood.
Will update patch and re-send.

Thank you.
Vadim

  reply	other threads:[~2018-01-25 11:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-18 15:42 [PATCH] net: ethernet: cavium: Correct Cacivum Thunderx nicvf/nicpf modules names Vadim Lomovtsev
2018-01-18 15:49 ` Vadim Lomovtsev
2018-01-18 15:53 ` [PATCH v2] net: ethernet: cavium: Correct Cavium " Vadim Lomovtsev
2018-01-18 18:18   ` Vadim Lomovtsev
2018-01-22 14:13   ` [PATCH v3] net: ethernet: cavium: Correct Cavium Thunderx NIC module and driver names Vadim Lomovtsev
2018-01-24 21:27     ` David Miller
2018-01-25 11:11       ` Vadim Lomovtsev [this message]
2018-01-25 11:38     ` [PATCH v4] net: ethernet: cavium: Correct Cavium Thunderx NIC driver names accordingly to module name Vadim Lomovtsev
2018-01-29 17:22       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180125111132.GA6458@localhost.localdomain \
    --to=vadim.lomovtsev@caviumnetworks.com \
    --cc=Vadim.Lomovtsev@cavium.com \
    --cc=davem@davemloft.net \
    --cc=dnelson@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rric@kernel.org \
    --cc=sgoutham@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).