From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH net-next 1/8] pkt_cls: add new tc cls helper to check
 offload flag and chain index
Date: Thu, 25 Jan 2018 11:26:52 -0800
Message-ID: <20180125112652.2d604720@cakuba.netronome.com>
References: <20180125001753.30408-1-jakub.kicinski@netronome.com>
        <20180125001753.30408-2-jakub.kicinski@netronome.com>
        <20180125080348.GA2159@nanopsycho>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: davem@davemloft.net, dsahern@gmail.com, netdev@vger.kernel.org,
        oss-drivers@netronome.com
To: Jiri Pirko <jiri@resnulli.us>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qt0-f179.google.com ([209.85.216.179]:35697 "EHLO
        mail-qt0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751011AbeAYT04 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 25 Jan 2018 14:26:56 -0500
Received: by mail-qt0-f179.google.com with SMTP id g14so22071020qti.2
        for <netdev@vger.kernel.org>; Thu, 25 Jan 2018 11:26:56 -0800 (PST)
In-Reply-To: <20180125080348.GA2159@nanopsycho>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 25 Jan 2018 09:03:48 +0100, Jiri Pirko wrote:
> >@@ -144,9 +144,6 @@ int nsim_bpf_setup_tc_block_cb(enum tc_setup_type type,
> > 		return -EOPNOTSUPP;
> > 	}
> > 
> >-	if (cls_bpf->common.chain_index)
> >-		return -EOPNOTSUPP;
> >-  
> 
> For nfp and netdevsim you do this in a patch that introduces the helper,
> for the rest you have a separate patch? Why this inconsistency?
> Again, from my perspective, this can be done in a single patch for all
> drivers. All the same hunks.

Ah, indeed, slightly sloppy.  This patch used to remove the
tc_can_offload_extack() helper hence the conversion here.
Let me split them out.