From: Christian Brauner <christian.brauner@canonical.com>
To: jbenc@redhat.com
Cc: netdev@vger.kernel.org, ebiederm@xmission.com,
davem@davemloft.net, dsahern@gmail.com, fw@strlen.de,
daniel@iogearbox.net, lucien.xin@gmail.com,
mschiffer@universe-factory.net, jakub.kicinski@netronome.com,
vyasevich@gmail.com, linux-kernel@vger.kernel.org,
w.bumiller@proxmox.com, nicolas.dichtel@6wind.com
Subject: Re: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK
Date: Thu, 25 Jan 2018 13:59:06 +0100 [thread overview]
Message-ID: <20180125125905.ahqrlmods5v56ucv@gmail.com> (raw)
In-Reply-To: <20180124142634.17766-1-christian.brauner@ubuntu.com>
On Wed, Jan 24, 2018 at 03:26:31PM +0100, Christian Brauner wrote:
> Hi,
>
> Based on the previous discussion this enables passing a IFLA_IF_NETNSID
> property along with RTM_SETLINK and RTM_DELLINK requests. The patch for
> RTM_NEWLINK will be sent out in a separate patch since there are more
> corner-cases to think about.
>
> Best,
> Christian
>
> Changelog 2018-01-24:
> * Preserve old behavior and report -ENODEV when either ifindex or ifname is
> provided and IFLA_GROUP is set. Spotted by Wolfgang Bumiller.
>
> Christian Brauner (3):
> rtnetlink: enable IFLA_IF_NETNSID in do_setlink()
> rtnetlink: enable IFLA_IF_NETNSID for RTM_SETLINK
> rtnetlink: enable IFLA_IF_NETNSID for RTM_DELLINK
>
> net/core/rtnetlink.c | 96 ++++++++++++++++++++++++++++++++++++++++------------
> 1 file changed, 75 insertions(+), 21 deletions(-)
>
> --
> 2.14.1
>
I've done more testing around enabling IFLA_IF_NETNSID for RTM_NEWLINK
as well and I think that the change is actually trivial. However, I
would like to wait before sending this patch out until we have agreed on
the patches for RTM_SETLINK and RTM_DELLINK in this series. Once we have
merged those I can just send another small commit. Or - if changes to
this patch series are required - I can just add it in a v2.
Thanks
Christian
next prev parent reply other threads:[~2018-01-25 12:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 14:26 [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK Christian Brauner
2018-01-24 14:26 ` [PATCH net-next 1/3 V1] rtnetlink: enable IFLA_IF_NETNSID in do_setlink() Christian Brauner
2018-01-24 14:26 ` [PATCH net-next 2/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_SETLINK Christian Brauner
2018-01-24 14:26 ` [PATCH net-next 3/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_DELLINK Christian Brauner
2018-01-24 15:24 ` [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK Nicolas Dichtel
2018-01-24 16:35 ` Jiri Benc
2018-01-25 14:20 ` Nicolas Dichtel
2018-01-25 22:30 ` Jiri Benc
2018-01-25 23:34 ` Nicolas Dichtel
2018-01-26 8:36 ` Jiri Benc
2018-01-26 9:28 ` Nicolas Dichtel
2018-01-25 12:59 ` Christian Brauner [this message]
2018-01-26 11:33 ` Christian Brauner
2018-01-29 16:31 ` David Miller
2018-01-29 17:09 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125125905.ahqrlmods5v56ucv@gmail.com \
--to=christian.brauner@canonical.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=ebiederm@xmission.com \
--cc=fw@strlen.de \
--cc=jakub.kicinski@netronome.com \
--cc=jbenc@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=mschiffer@universe-factory.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=vyasevich@gmail.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).