From: Andrew Lunn <andrew@lunn.ch>
To: Wang Dongsheng <dongsheng.wang@hxt-semitech.com>
Cc: timur@codeaurora.org, hpuranik@codeaurora.org,
yu.zheng@hxt-semitech.com, netdev@vger.kernel.org,
Marcin Wojtas <mw@semihalf.com>
Subject: Re: [RFC] net: qcom/emac: mdiobus-dev fwnode should point to emac-adev
Date: Thu, 25 Jan 2018 15:15:15 +0100 [thread overview]
Message-ID: <20180125141515.GB16547@lunn.ch> (raw)
In-Reply-To: <1516860879-15798-1-git-send-email-dongsheng.wang@hxt-semitech.com>
On Wed, Jan 24, 2018 at 10:14:39PM -0800, Wang Dongsheng wrote:
> mdiobus always try to get a GPIO "reset" consumer, based on ACPI
> the GPIO should be described in emac-adev _DSD or _CRS.
>
> ACPI uses mido common API to register, however mdio->dev->fwnode is not
> pointing to any adev. So the "reset" consumer can never be found.
>
> OF has done this by using an of_mdiobus_register. The mdiobus get emac
> of_node and go through the of_node to find a GPIO "reset" consumer.
>
> Not sure, ACPI needs to add the same API for mdio just like OF because
> mdio isn't a real entity in ACPI. So I think there isn't any work in
> ACPI, the mac driver needs to take adev to mdiobus when mido-bus is
> registering.
Hi Wang
People are working on an ACPI description for MDIO. There have been
some discussion about this in the thread "Armada 7k/8k PP2 ACPI
support".
If i'm reading your patch correctly, you are looking for the MDIO
reset in the MAC node. This is wrong. It is an MDIO property, so
should be in the MDIO device. Once we have figured out how to
represent MDIO busses in ACPI, the reset will be in the MDIO node.
I don't recommend you do this. It will mean your device is different
to every other device using ACPI for MDIO. A better approach is to
take part in the discussion about how to represent MDIO busses and
PHYs in ACPI.
Andrew
next prev parent reply other threads:[~2018-01-25 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 6:14 [RFC] net: qcom/emac: mdiobus-dev fwnode should point to emac-adev Wang Dongsheng
2018-01-25 14:15 ` Andrew Lunn [this message]
2018-01-25 15:40 ` Timur Tabi
2018-01-25 15:59 ` Andrew Lunn
2018-01-25 16:05 ` Timur Tabi
2018-01-26 7:20 ` Wang, Dongsheng
2018-01-30 13:21 ` Andrew Lunn
2018-01-25 14:36 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125141515.GB16547@lunn.ch \
--to=andrew@lunn.ch \
--cc=dongsheng.wang@hxt-semitech.com \
--cc=hpuranik@codeaurora.org \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=timur@codeaurora.org \
--cc=yu.zheng@hxt-semitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).