From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [PATCH net-next v2 00/12] net: sched: propagate extack to cls offloads on destroy and only with skip_sw Date: Thu, 25 Jan 2018 13:11:57 -0200 Message-ID: <20180125151157.GA12972@localhost.localdomain> References: <20180124205424.6976-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, jiri@resnulli.us, dsahern@gmail.com, daniel@iogearbox.net, john.fastabend@gmail.com, netdev@vger.kernel.org, oss-drivers@netronome.com, aring@mojatatu.com To: Jakub Kicinski Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:39374 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbeAYPMA (ORCPT ); Thu, 25 Jan 2018 10:12:00 -0500 Received: by mail-wm0-f66.google.com with SMTP id b21so15548250wme.4 for ; Thu, 25 Jan 2018 07:12:00 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180124205424.6976-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Jan 24, 2018 at 12:54:12PM -0800, Jakub Kicinski wrote: > Hi! > > This series some of Jiri's comments and the fact that today drivers > may produce extack even if there is no skip_sw flag (meaning the > driver failure is not really a problem), and warning messages will > only confuse the users. It's a fair point, but I think this is not the best solution. How will the user then know why it failed to install in hw? Will have to install a new rule, just with skip_sw, and hope that it fails with the same reason? Maybe it's better to let tc/ovs/etc only exhibit this information under a certain log/debug level. Marcelo