From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [PATCH v2 0/4] Check size of packets before sending Date: Thu, 25 Jan 2018 13:24:42 -0200 Message-ID: <20180125152442.GE3502@localhost.localdomain> References: <20180125043109.28332-1-dja@axtens.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jason Wang , Manish.Chopra-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org To: Daniel Axtens Return-path: Content-Disposition: inline In-Reply-To: <20180125043109.28332-1-dja-Yfaxwxk/+vWsTnJN9+BGXg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Errors-To: ovs-dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org List-Id: netdev.vger.kernel.org On Thu, Jan 25, 2018 at 03:31:05PM +1100, Daniel Axtens wrote: > There are a few ways we can send packets that are too large to a > network driver. > > When non-GSO packets are forwarded, we validate their size, based on > the MTU of the destination device. However, when GSO packets are > forwarded, we do not validate their size. We implicitly assume that > when they are segmented, the resultant packets will be correctly > sized. ... Patchset LGTM, but I also think it's risky merging this one in by now. Marcelo